Bug 1491561 follow-up: Add back Cu.createCommandParams() which was accidentally removed
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 18 Sep 2018 10:47:04 -0400
changeset 437108 5fb38b2b939c28fa13a6396414e36eade5cb3fb7
parent 437107 3655d882ad9c1762ffc8af04f8962cae986ee8f4
child 437109 4fc9fae13df7a7a1cf3d47483164e3cee55e801a
push id34668
push useraiakab@mozilla.com
push dateWed, 19 Sep 2018 02:19:16 +0000
treeherdermozilla-central@a9e339b3e5d8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1491561
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1491561 follow-up: Add back Cu.createCommandParams() which was accidentally removed
js/xpconnect/idl/xpccomponents.idl
js/xpconnect/src/XPCComponents.cpp
--- a/js/xpconnect/idl/xpccomponents.idl
+++ b/js/xpconnect/idl/xpccomponents.idl
@@ -722,16 +722,19 @@ interface nsIXPCComponents_Utils : nsISu
     void recordReplayDirective(in long directive);
 
     /* Create a spellchecker object. */
     nsIEditorSpellCheck createSpellChecker();
 
     /* Create a commandline object. */
     nsISupports createCommandLine();
 
+    /* Create a command params object. */
+    nsICommandParams createCommandParams();
+
     /* Create a loadcontext object. */
     nsILoadContext createLoadContext();
 
     /* Create a private loadcontext object. */
     nsILoadContext createPrivateLoadContext();
 
     /* Create a persistent property object. */
     nsIPersistentProperties createPersistentProperties();
--- a/js/xpconnect/src/XPCComponents.cpp
+++ b/js/xpconnect/src/XPCComponents.cpp
@@ -3229,16 +3229,25 @@ nsXPCComponents_Utils::CreateCommandLine
 {
     NS_ENSURE_ARG_POINTER(aCommandLine);
     nsCOMPtr<nsISupports> commandLine = new nsCommandLine();
     commandLine.forget(aCommandLine);
     return NS_OK;
 }
 
 NS_IMETHODIMP
+nsXPCComponents_Utils::CreateCommandParams(nsICommandParams** aCommandParams)
+{
+    NS_ENSURE_ARG_POINTER(aCommandParams);
+    nsCOMPtr<nsICommandParams> commandParams = new nsCommandParams();
+    commandParams.forget(aCommandParams);
+    return NS_OK;
+}
+
+NS_IMETHODIMP
 nsXPCComponents_Utils::CreateLoadContext(nsILoadContext** aLoadContext)
 {
     NS_ENSURE_ARG_POINTER(aLoadContext);
     nsCOMPtr<nsILoadContext> loadContext = ::CreateLoadContext();
     loadContext.forget(aLoadContext);
     return NS_OK;
 }