Backed out changeset e855e9c6b125 (bug 1537772) for devtools failures in browser_aboutdebugging_process_main.js CLOSED TREE
authorNoemi Erli <nerli@mozilla.com>
Wed, 27 Mar 2019 23:34:14 +0200
changeset 466464 5dfec5266b7c4b495eba11d0e27e8135036ec7f1
parent 466463 d1e03f3bba1aabd64389e3c98c660242c6d59bb9
child 466465 5e22dbefa98b9bd78c8a4fff69764b443ff6c74f
push id35768
push useropoprus@mozilla.com
push dateThu, 28 Mar 2019 09:55:54 +0000
treeherdermozilla-central@c045dd97faf2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1537772
milestone68.0a1
backs oute855e9c6b125de77fbfa28c5302cc0cf378c75f0
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset e855e9c6b125 (bug 1537772) for devtools failures in browser_aboutdebugging_process_main.js CLOSED TREE
devtools/client/aboutdebugging-new/src/components/CompatibilityWarning.js
devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js
devtools/client/aboutdebugging-new/src/middleware/process-component-data.js
devtools/client/locales/en-US/aboutdebugging.ftl
--- a/devtools/client/aboutdebugging-new/src/components/CompatibilityWarning.js
+++ b/devtools/client/aboutdebugging-new/src/components/CompatibilityWarning.js
@@ -33,25 +33,25 @@ class CompatibilityWarning extends PureC
     if (status === COMPATIBILITY_STATUS.COMPATIBLE) {
       return null;
     }
 
     let localizationId, statusClassName;
     switch (status) {
       case COMPATIBILITY_STATUS.TOO_OLD:
         statusClassName = "js-compatibility-warning-too-old";
-        localizationId = "about-debugging-browser-version-too-old";
+        localizationId = "about-debugging-runtime-version-too-old";
         break;
       case COMPATIBILITY_STATUS.TOO_RECENT:
         statusClassName = "js-compatibility-warning-too-recent";
-        localizationId = "about-debugging-browser-version-too-recent";
+        localizationId = "about-debugging-runtime-version-too-recent";
         break;
       case COMPATIBILITY_STATUS.TOO_OLD_67_DEBUGGER:
         statusClassName = "js-compatibility-warning-too-old-67-debugger";
-        localizationId = "about-debugging-browser-version-too-old-67-debugger";
+        localizationId = "about-debugging-runtime-version-too-old-67-debugger";
         break;
     }
 
     return Message(
       {
         level: MESSAGE_LEVEL.WARNING,
       },
       Localized(
--- a/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js
+++ b/devtools/client/aboutdebugging-new/src/components/sidebar/SidebarRuntimeItem.js
@@ -50,17 +50,17 @@ class SidebarRuntimeItem extends PureCom
       )
     );
   }
 
   renderName() {
     const { deviceName, getString, isUnknown, name } = this.props;
 
     const displayName = isUnknown ?
-      getString("about-debugging-sidebar-runtime-item-waiting-for-browser") : name;
+      getString("about-debugging-sidebar-runtime-item-waiting-for-runtime") : name;
 
     const localizationId = deviceName
       ? "about-debugging-sidebar-runtime-item-name"
       : "about-debugging-sidebar-runtime-item-name-no-device";
 
     const className = "ellipsis-text sidebar-runtime-item__runtime";
 
     function renderWithDevice() {
--- a/devtools/client/aboutdebugging-new/src/middleware/process-component-data.js
+++ b/devtools/client/aboutdebugging-new/src/middleware/process-component-data.js
@@ -27,17 +27,17 @@ const processComponentDataMiddleware = s
   return next(action);
 };
 
 function toMainProcessComponentData(process) {
   const type = DEBUG_TARGETS.PROCESS;
   const id = process.processFront.actorID;
   const icon = "chrome://devtools/skin/images/settings.svg";
   const name = l10n.getString("about-debugging-main-process-name");
-  const description = l10n.getString("about-debugging-main-process-description2");
+  const description = l10n.getString("about-debugging-main-process-description");
 
   return {
     name,
     icon,
     id,
     type,
     details: {
       description,
--- a/devtools/client/locales/en-US/aboutdebugging.ftl
+++ b/devtools/client/locales/en-US/aboutdebugging.ftl
@@ -45,20 +45,20 @@ about-debugging-sidebar-no-devices = No 
 # Text displayed in buttons found in sidebar items representing remote runtimes.
 # Clicking on the button will attempt to connect to the runtime.
 about-debugging-sidebar-item-connect-button = Connect
 
 # Temporary text displayed in sidebar items representing remote runtimes after
 # successfully connecting to them. Temporary UI, do not localize.
 about-debugging-sidebar-item-connected-label = Connected
 
-# Text displayed in sidebar items for remote devices where a compatible browser (eg
+# Text displayed in sidebar items for remote devices where a compatible runtime (eg
 # Firefox) has not been detected yet. Typically, Android phones connected via USB with
 # USB debugging enabled, but where Firefox is not started.
-about-debugging-sidebar-runtime-item-waiting-for-browser = Waiting for browser…
+about-debugging-sidebar-runtime-item-waiting-for-runtime = Waiting for runtime…
 
 # Title for runtime sidebar items that are related to a specific device (USB, WiFi).
 about-debugging-sidebar-runtime-item-name =
   .title = { $displayName } ({ $deviceName })
 # Title for runtime sidebar items where we cannot get device information (network
 # locations).
 about-debugging-sidebar-runtime-item-name-no-device =
   .title = { $displayName }
@@ -188,37 +188,37 @@ about-debugging-runtime-processes =
 # runtimes.
 about-debugging-runtime-profile-button = Profile Runtime
 
 # This string is displayed in the runtime page if the current configuration of the
 # target runtime is incompatible with service workers. "Learn more" points to MDN.
 # https://developer.mozilla.org/en-US/docs/Tools/about%3Adebugging#Service_workers_not_compatible
 about-debugging-runtime-service-workers-not-compatible = Your browser configuration is not compatible with Service Workers. <a>Learn more</a>
 
-# This string is displayed in the runtime page if the remote browser version is too old.
+# This string is displayed in the runtime page if the remote runtime version is too old.
 # "Troubleshooting" link points to https://developer.mozilla.org/docs/Tools/WebIDE/Troubleshooting
-# { $runtimeVersion } is the version of the remote browser (for instance "67.0a1")
+# { $runtimeVersion } is the version of the remote runtime (for instance "67.0a1")
 # { $minVersion } is the minimum version that is compatible with the current Firefox instance (same format)
-about-debugging-browser-version-too-old = The connected browser has an old version ({ $runtimeVersion }). The minimum supported version is ({ $minVersion }). This is an unsupported setup and may cause DevTools to fail. Please update the connected browser. <a>Troubleshooting</a>
+about-debugging-runtime-version-too-old = The connected runtime has an old version ({ $runtimeVersion }). The minimum supported version is ({ $minVersion }). This is an unsupported setup and may cause DevTools to fail. Please update the connected runtime. <a>Troubleshooting</a>
 
 # Dedicated message for a backward compatibility issue that occurs when connecting:
 # - from Fx 67 to 66 or to 65
 # - from Fx 68 to 66
 # Those are normally in range for DevTools compatibility policy, but specific non
 # backward compatible changes broke the debugger in those scenarios (Bug 1528219).
-# { $runtimeVersion } is the version of the remote browser (for instance "67.0a1")
-about-debugging-browser-version-too-old-67-debugger = The Debugger panel may not work with the connected browser. Please use Firefox { $runtimeVersion } if you need to use the Debugger with this browser.
+# { $runtimeVersion } is the version of the remote runtime (for instance "67.0a1")
+about-debugging-runtime-version-too-old-67-debugger = The Debugger panel may not work with the connected runtime. Please use Firefox { $runtimeVersion } if you need to use the Debugger with this runtime.
 
-# This string is displayed in the runtime page if the remote browser version is too recent.
+# This string is displayed in the runtime page if the remote runtime version is too recent.
 # "Troubleshooting" link points to https://developer.mozilla.org/en-US/docs/Tools/WebIDE/Troubleshooting
-# { $runtimeID } is the build ID of the remote browser (for instance "20181231", format is yyyyMMdd)
+# { $runtimeID } is the build ID of the remote runtime (for instance "20181231", format is yyyyMMdd)
 # { $localID } is the build ID of the current Firefox instance (same format)
-# { $runtimeVersion } is the version of the remote browser (for instance "67.0a1")
-# { $localVersion } is the version of your current browser (same format)
-about-debugging-browser-version-too-recent = The connected browser is more recent ({ $runtimeVersion }, buildID { $runtimeID }) than your { -brand-shorter-name } ({ $localVersion }, buildID { $localID }). This is an unsupported setup and may cause DevTools to fail. Please update Firefox. <a>Troubleshooting</a>
+# { $runtimeVersion } is the version of the remote runtime (for instance "67.0a1")
+# { $localVersion } is the version of your current runtime (same format)
+about-debugging-runtime-version-too-recent = The connected runtime is more recent ({ $runtimeVersion }, buildID { $runtimeID }) than your { -brand-shorter-name } ({ $localVersion }, buildID { $localID }). This is an unsupported setup and may cause DevTools to fail. Please update Firefox. <a>Troubleshooting</a>
 
 # Displayed for runtime info in runtime pages.
 # { $name } is brand name such as "Firefox Nightly"
 # { $version } is version such as "64.0a1"
 about-debugging-runtime-name = { $name } ({ $version })
 
 # Text of a button displayed in Runtime pages for remote runtimes.
 # Clicking on the button will close the connection to the runtime.
@@ -342,10 +342,10 @@ about-debugging-worker-scope =
 about-debugging-worker-push-service =
   .label = Push Service
 
 # Displayed as name for the Main Process debug target in the Processes category. Only for
 # remote runtimes, if `devtools.aboutdebugging.process-debugging` is true.
 about-debugging-main-process-name = Main Process
 
 # Displayed as description for the Main Process debug target in the Processes category.
-# Only for remote browsers, if `devtools.aboutdebugging.process-debugging` is true.
-about-debugging-main-process-description2 = Main Process for the target browser
+# Only for remote runtimes, if `devtools.aboutdebugging.process-debugging` is true.
+about-debugging-main-process-description = Main Process for the target runtime