Bug 1668565 - Update help for --setpref in Raptor/talos r=perftest-reviewers,sparky
authorTed Campbell <tcampbell@mozilla.com>
Fri, 02 Oct 2020 13:42:33 +0000
changeset 551285 5d305d85f70c32d050cb01ac90f06a7d465ac28a
parent 551284 4c92b9d3c7d8d58ef42148232edde5c30149f61e
child 551286 91d1ee513a26355e49e8379c425dc833beeffcdc
push id37830
push usernbeleuzu@mozilla.com
push dateSat, 03 Oct 2020 10:23:35 +0000
treeherdermozilla-central@7d7faf0b6d7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersperftest-reviewers, sparky
bugs1668565
milestone83.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1668565 - Update help for --setpref in Raptor/talos r=perftest-reviewers,sparky Differential Revision: https://phabricator.services.mozilla.com/D92069
testing/mozharness/mozharness/mozilla/testing/raptor.py
testing/mozharness/mozharness/mozilla/testing/talos.py
testing/raptor/raptor/cmdline.py
testing/talos/talos/cmdline.py
--- a/testing/mozharness/mozharness/mozilla/testing/raptor.py
+++ b/testing/mozharness/mozharness/mozilla/testing/raptor.py
@@ -310,19 +310,20 @@ class Raptor(TestingMixin, MercurialScri
         [["--enable-fission"], {
             "action": "store_true",
             "dest": "enable_fission",
             "default": False,
             "help": "Enable Fission (site isolation) in Gecko.",
         }],
         [["--setpref"], {
             "action": "append",
+            "metavar": "PREF=VALUE",
             "dest": "extra_prefs",
             "default": [],
-            "help": "A preference to set. Must be a key-value pair separated by a ':'."
+            "help": "Set a browser preference. May be used multiple times."
         }],
         [["--cold"], {
             "action": "store_true",
             "dest": "cold",
             "default": False,
             "help": "Enable cold page-load for browsertime tp6",
         }],
         [["--verbose"], {
--- a/testing/mozharness/mozharness/mozilla/testing/talos.py
+++ b/testing/mozharness/mozharness/mozilla/testing/talos.py
@@ -158,18 +158,18 @@ class Talos(TestingMixin, MercurialScrip
             "default": False,
             "help": "Enable Fission (site isolation) in Gecko.",
         }],
         [["--setpref"], {
             "action": "append",
             "metavar": "PREF=VALUE",
             "dest": "extra_prefs",
             "default": [],
-            "help": "Defines an extra user preference."}
-         ],
+            "help": "Set a browser preference. May be used multiple times.",
+         }],
     ] + testing_config_options + copy.deepcopy(code_coverage_config_options)
 
     def __init__(self, **kwargs):
         kwargs.setdefault('config_options', self.config_options)
         kwargs.setdefault('all_actions', ['clobber',
                                           'download-and-extract',
                                           'populate-webroot',
                                           'create-virtualenv',
--- a/testing/raptor/raptor/cmdline.py
+++ b/testing/raptor/raptor/cmdline.py
@@ -155,17 +155,18 @@ def create_parser(mach_interface=False):
             help="Enable the WebRender compositor in Gecko.")
     add_arg('--no-conditioned-profile', dest="no_conditioned_profile", action="store_true",
             default=False, help="Run Raptor tests without a conditioned profile.")
     add_arg('--device-name', dest="device_name", default=None,
             type=str, help="Device name of mobile device.")
     add_arg('--enable-fission', dest="enable_fission", action="store_true", default=False,
             help="Enable Fission (site isolation) in Gecko.")
     add_arg('--setpref', dest="extra_prefs", action="append", default=[],
-            help="A preference to set. Must be a key-value pair separated by a ':'.")
+            metavar="PREF=VALUE",
+            help="Set a browser preference. May be used multiple times.")
     if not mach_interface:
         add_arg('--run-local', dest="run_local", default=False, action="store_true",
                 help="Flag which indicates if Raptor is running locally or in production")
         add_arg('--obj-path', dest="obj_path", default=None,
                 help="Browser-build obj_path (received when running in production)")
     add_arg('--noinstall', dest="noinstall", default=False, action="store_true",
             help="Flag which indicates if Raptor should not offer to install Android APK.")
     add_arg('--installerpath', dest="installerpath", default=None, type=str,
--- a/testing/talos/talos/cmdline.py
+++ b/testing/talos/talos/cmdline.py
@@ -110,17 +110,17 @@ def create_parser(mach_interface=False):
     add_arg('--test_timeout', type=int, default=1200,
             help="Time to wait for the browser to output to the log file")
     add_arg('--errorFile', dest='error_filename',
             default=os.path.abspath('browser_failures.txt'),
             help="Filename to store the errors found during the test."
                  " Currently used for xperf only.")
     add_arg('--setpref', action='append', default=[], dest="extraPrefs",
             metavar="PREF=VALUE",
-            help="defines an extra user preference")
+            help="Set a browser preference. May be used multiple times.")
     add_arg("--firstNonBlankPaint", action='store_true', dest="fnbpaint",
             help="Wait for firstNonBlankPaint event before recording the time")
     add_arg("--pdfPaint", action='store_true', dest="pdfpaint",
             help="Wait for the first page of a PDF to be rendered")
     add_arg('--webServer', dest='webserver',
             help="DEPRECATED")
     if not mach_interface:
         add_arg('--develop', action='store_true', default=False,