Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 24 May 2019 07:19:58 +0000
changeset 475384 5d10803def3ee7f35ee69f4a67870e7f9885e79a
parent 475383 08973de3de9ec12109ad5101d24f79ff710b6da8
child 475385 8e672b4e0a3e3ed151a91abbca41cebf2692dd4f
push id36060
push usercbrindusan@mozilla.com
push dateFri, 24 May 2019 21:47:21 +0000
treeherdermozilla-central@ac95bdf3c0b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs1121623
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1121623 part 2. Switch AddonManagerPermissions to being a namespace. r=peterv Differential Revision: https://phabricator.services.mozilla.com/D32200
dom/bindings/Bindings.conf
dom/bindings/parser/WebIDL.py
dom/webidl/AddonManager.webidl
--- a/dom/bindings/Bindings.conf
+++ b/dom/bindings/Bindings.conf
@@ -48,21 +48,16 @@
 # descriptor to use when generating that interface's binding.
 
 DOMInterfaces = {
 
 'AbstractWorker': {
     'concrete': False
 },
 
-'AddonManagerPermissions': {
-    'wrapperCache': False,
-    'concrete': False
-},
-
 'AnimationEffect': {
     'concrete': False
 },
 
 'AnimationTimeline': {
     'concrete': False
 },
 
--- a/dom/bindings/parser/WebIDL.py
+++ b/dom/bindings/parser/WebIDL.py
@@ -1804,17 +1804,19 @@ class IDLNamespace(IDLInterfaceOrNamespa
                 if not attr.hasValue():
                     raise WebIDLError("[%s] must have a value" % identifier,
                                       [attr.location])
             elif (identifier == "ProtoObjectHack" or
                   identifier == "ChromeOnly"):
                 if not attr.noArguments():
                     raise WebIDLError("[%s] must not have arguments" % identifier,
                                       [attr.location])
-            elif identifier == "Pref" or identifier == "Func":
+            elif (identifier == "Pref" or
+                  identifier == "HeaderFile" or
+                  identifier == "Func"):
                 # Known extended attributes that take a string value
                 if not attr.hasValue():
                     raise WebIDLError("[%s] must have a value" % identifier,
                                       [attr.location])
             else:
                 raise WebIDLError("Unknown extended attribute %s on namespace" %
                                   identifier,
                                   [attr.location])
--- a/dom/webidl/AddonManager.webidl
+++ b/dom/webidl/AddonManager.webidl
@@ -78,12 +78,12 @@ interface AddonManager : EventTarget {
    */
   Promise<AddonInstall> createInstall(optional addonInstallOptions options);
 
   // Indicator to content whether permissions prompts are enabled
   readonly attribute boolean permissionPromptsEnabled;
 };
 
 [ChromeOnly,Exposed=Window,HeaderFile="mozilla/AddonManagerWebAPI.h"]
-interface AddonManagerPermissions {
-  static boolean isHostPermitted(DOMString host);
+namespace AddonManagerPermissions {
+  boolean isHostPermitted(DOMString host);
 };