Bug 1544225 - Fix more background colors and icon fill colors for about:preferences dark mode r=dao
authorKestrel <ke5trel@protonmail.com>
Fri, 26 Apr 2019 11:55:07 +0000
changeset 471493 5ca84ee52da5ae45560093ab1d40557939e9c3c4
parent 471492 de47bf15eea8a49c16af2568c8675d14412913d8
child 471494 7e39562216125471121260f5f9775be2a6432d65
push id35920
push useraiakab@mozilla.com
push dateFri, 26 Apr 2019 22:02:33 +0000
treeherdermozilla-central@b13f2b24ae62 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1544225
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1544225 - Fix more background colors and icon fill colors for about:preferences dark mode r=dao Differential Revision: https://phabricator.services.mozilla.com/D28081
browser/themes/shared/incontentprefs/preferences.inc.css
browser/themes/shared/incontentprefs/privacy.css
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -197,27 +197,38 @@ button > hbox > label {
   align-items: center;
   justify-content: space-between;
 }
 
 .header[hidden=true] {
   display: none;
 }
 
+/* All panes */
+
+.info-icon,
+.androidIcon,
+.iOSIcon,
+#updateSettingCrossUserWarning,
+.extension-controlled > description {
+  -moz-context-properties: fill;
+  fill: currentColor;
+}
+
 /* General Pane */
 
 #isDefaultLabel {
   font-weight: 600;
 }
 
 .info-panel,
 .extension-controlled {
   margin-top: 18px !important;
   margin-bottom: 18px !important;
-  background: var(--grey-20);
+  background: var(--in-content-warning-container);
   border-radius: 5px;
   padding-inline-end: 10px;
 }
 
 .info-panel > description,
 .extension-controlled > description {
   line-height: 16px;
   background: url(chrome://browser/skin/identity-icon.svg) 10px 14px no-repeat;
@@ -663,18 +674,16 @@ button > hbox > label {
 
 .androidIcon,
 .iOSIcon {
   margin-inline-start: 2px;
   margin-inline-end: 4px;
   width: 20px;
   height: 20px;
   vertical-align: text-bottom;
-  -moz-context-properties: fill;
-  fill: currentColor;
 }
 
 #updateDeck > hbox > label {
   margin-inline-end: 5px ! important;
 }
 
 .update-throbber {
   width: 16px;
@@ -723,26 +732,24 @@ image.update-throbber {
 
 #policies-container,
 #searchInput {
   min-height: 32px;
   margin: 20px 0 30px 0px;
 }
 
 #policies-container {
-  background-color: #ededf0;
+  background-color: var(--in-content-warning-container);
   padding: 0px 8px;
   margin-inline-end: 16px;
   border-radius: 2px;
 }
 
 .info-icon {
   list-style-image: url("chrome://browser/skin/identity-icon.svg");
-  fill: currentColor;
-  -moz-context-properties: fill;
   width: 16px;
   height: 16px;
   margin-top: calc((32px - 16px) / 2);
 }
 
 .sticky-container {
   position: sticky;
   background-color: var(--in-content-page-background);
@@ -923,17 +930,17 @@ menulist[indicator=true] > menupopup men
   padding-block-end: 8px;
   margin-block-end: 17px;
 }
 
 #updateSettingCrossUserWarning {
   padding-inline-start: 30px;
   margin-block-start: 20px;
   line-height: 20px;
-  background-image: url("chrome://global/skin/icons/info.svg");
+  background-image: url("chrome://browser/skin/identity-icon.svg");
   background-position-x: left 2px;
   background-position-y: top 2px;
   background-size: 16px 16px;
   background-repeat: no-repeat;
 }
 
 #updateSettingCrossUserWarning:-moz-locale-dir(rtl) {
   background-position-x: right 2px;
--- a/browser/themes/shared/incontentprefs/privacy.css
+++ b/browser/themes/shared/incontentprefs/privacy.css
@@ -49,17 +49,20 @@
 #contentBlockingFingerprintersCheckbox[checked] > .checkbox-label-box {
   list-style-image: url("chrome://browser/skin/controlcenter/fingerprinters-disabled.svg");
 }
 
 .content-blocking-icon,
 .permission-icon,
 .content-blocking-category .checkbox-label-box,
 .extra-information-label > image,
-.arrowhead {
+.arrowhead,
+.content-blocking-info-image,
+.reload-tabs-button,
+.content-blocking-warning-image {
   -moz-context-properties: fill;
   fill: currentColor;
 }
 
 .content-blocking-icon[disabled] {
   fill: GrayText;
 }
 
@@ -176,18 +179,16 @@
 .content-blocking-warning.reload-tabs .content-blocking-info-image {
   list-style-image: url(chrome://browser/skin/identity-icon.svg);
   margin-top: 5px;
   margin-inline-end: 8px;
   margin-inline-start: 4px;
 }
 
 .reload-tabs-button {
-  -moz-context-properties: fill;
-  fill: currentColor;
   max-height: 30px;
   min-height: 30px;
   padding: 0 20px;
   list-style-image: url("chrome://browser/skin/reload.svg");
   background-color: var(--blue-50);
 }
 
 .reload-tabs-button:not([disabled="true"]):hover {
@@ -274,18 +275,16 @@
 
 .content-blocking-fingerprinters-image {
   list-style-image: url("chrome://browser/skin/controlcenter/fingerprinters-disabled.svg");
   margin-inline-end: 5px;
 }
 
 .content-blocking-warning-image {
   list-style-image: url("chrome://global/skin/icons/warning.svg");
-  -moz-context-properties: fill;
-  fill: currentColor;
   margin-inline-end: 8px;
   margin-inline-start: 4px;
 }
 
 #blockCookiesMenu,
 #trackingProtectionMenu {
   margin: 0;
 }