Bug 1472379 [wpt PR 11740] - [html] Do not return value from cleanup fns, a=testonly
authorMike Pennisi <mike@mikepennisi.com>
Sat, 07 Jul 2018 00:03:42 +0000
changeset 426130 5c89001100bf5a44fa6a8e42c5f25d8946ce930a
parent 426129 99f8104e102031f0c9e931f1dc02abd6e286d39a
child 426131 69c13f6a5171a209ba5ad16ae551a38f5b5a1d50
push id34267
push userrgurzau@mozilla.com
push dateWed, 11 Jul 2018 22:05:21 +0000
treeherdermozilla-central@3aca103e4915 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1472379, 11740
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472379 [wpt PR 11740] - [html] Do not return value from cleanup fns, a=testonly Automatic update from web-platform-tests[html] Do not return value from cleanup fns Today, the return value of functions provided to the `Test#add_cleanup` function has no effect on the behavior of the test runner. Despite this, some existing tests have already been authored to return a value: the result of `Element#removeChild`. An upcoming feature addition to testharness.js will cause the return value to influence test results [1]. To allow the new test harness feature to land without introducing harness errors, refactor existing tests to omit a return value. [1] https://github.com/web-platform-tests/wpt/issues/6075 -- wpt-commits: 21369c1a88085d4804d520887978392d19c8c656 wpt-pr: 11740
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/attributes.sub.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -582689,17 +582689,17 @@
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
    "support"
   ],
   "html/infrastructure/urls/resolving-urls/.gitkeep": [
    "da39a3ee5e6b4b0d3255bfef95601890afd80709",
    "support"
   ],
   "html/infrastructure/urls/resolving-urls/query-encoding/attributes.sub.html": [
-   "a467530a931aae564a73518487b12521c6dd6377",
+   "d86f78ff4108cc4775ca5414a8d2f3e0b669fa3a",
    "testharness"
   ],
   "html/infrastructure/urls/resolving-urls/query-encoding/location.sub.html": [
    "34aa7e5a7d4daba412fa700859913cf9def77565",
    "testharness"
   ],
   "html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html": [
    "582924c0e77e2519c4bac3f5bdc00f55a35f715b",
--- a/testing/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/attributes.sub.html
+++ b/testing/web-platform/tests/html/infrastructure/urls/resolving-urls/query-encoding/attributes.sub.html
@@ -20,17 +20,17 @@ function expected(encoding) {
 function assert_ends_with(input, endsWith) {
   assert_true(input.endsWith(endsWith), input + " did not end with " + endsWith);
 }
 
 "body table thead tbody tfoot tr td th".split(" ").forEach(localName => {
   test(t => {
     const elm = document.createElement(localName);
     document.body.appendChild(elm);
-    t.add_cleanup(() => document.body.removeChild(elm));
+    t.add_cleanup(() => { document.body.removeChild(elm); });
     elm.setAttribute("background", "?\u00FF");
     assert_ends_with(getComputedStyle(elm).backgroundImage, expected(document.characterSet) + "\")");
   }, "getComputedStyle <" + localName + " background>");
 });
 
 function test_url_reflecting(localName, attr, idlAttr) {
   idlAttr = idlAttr || attr;
   test(() => {