Bug 996796 patch 0 - Fix test_animations_omta_start.html so that additional tests will involve onscreen layers. r=birtles
authorL. David Baron <dbaron@dbaron.org>
Thu, 24 Jul 2014 21:35:33 -0700
changeset 196105 5bed5f6da61ce3878cac0c5334423a709e42bd4f
parent 196104 267e2477f763c4f216fe05b58434e1d70efbf137
child 196106 fa40edea370500921e38b400b61f0438d05b4cff
push id27205
push userkwierso@gmail.com
push dateFri, 25 Jul 2014 22:59:38 +0000
treeherdermozilla-central@e07264876182 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs996796
milestone34.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 996796 patch 0 - Fix test_animations_omta_start.html so that additional tests will involve onscreen layers. r=birtles This removes each test element when we're done with it so that each successive test element isn't 100px lower. This is required to keep the third test element (added in the next patch) onscreen when running tests on the B2G emulator (other than when running a single test at a time). This, in turn, is required to get animations in that test properly shipped to the compositor thread, which is required for the test to pass.
layout/style/test/test_animations_omta_start.html
--- a/layout/style/test/test_animations_omta_start.html
+++ b/layout/style/test/test_animations_omta_start.html
@@ -89,17 +89,17 @@ function testTransform() {
 
   waitForAllPaints(function() {
     gUtils.advanceTimeAndRefresh(10100);
     waitForAllPaints(function() {
       var transform = gUtils.getOMTAStyle(target, "transform");
       ok(matricesRoughlyEqual(convertTo3dMatrix(transform),
                               convertTo3dMatrix("matrix(1, 0, 0, 1, 50, 0)")),
          "transform is set on compositor thread after delayed start");
-      target.removeAttribute("style");
+      target.remove();
       gUtils.restoreNormalRefresh();
       testBackwardsFill();
     });
   });
 }
 
 function testBackwardsFill() {
   gUtils.advanceTimeAndRefresh(0);
@@ -115,17 +115,17 @@ function testBackwardsFill() {
     waitForAllPaints(function() {
       gUtils.advanceTimeAndRefresh(100);
       waitForAllPaints(function() {
         var transform = gUtils.getOMTAStyle(target, "transform");
         ok(matricesRoughlyEqual(convertTo3dMatrix(transform),
                                 convertTo3dMatrix("matrix(1, 0, 0, 1, 1, 0)")),
            "transform is set on compositor thread after delayed start " +
            "with backwards fill");
-        target.removeAttribute("style");
+        target.remove();
         gUtils.restoreNormalRefresh();
         SimpleTest.finish();
       });
     });
   });
 }
 
 </script>