Bug 1638175 - split valgrind args using shlex.split rather than str.split, r=gbrown.
authorBob Clary <bclary@bclary.com>
Fri, 29 May 2020 15:48:45 +0000
changeset 533004 5b828de27b663239abbe1e17a273a313b88d826c
parent 533003 da329064b7ef97c7a03ad17578c9e0cd4157f87d
child 533005 594ac84515dc7eeddd1d09071e4d6591524d8910
push id37461
push userccoroiu@mozilla.com
push dateFri, 29 May 2020 21:46:31 +0000
treeherdermozilla-central@a58cc68b0c51 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1638175
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1638175 - split valgrind args using shlex.split rather than str.split, r=gbrown. Differential Revision: https://phabricator.services.mozilla.com/D77475
testing/mochitest/runtests.py
--- a/testing/mochitest/runtests.py
+++ b/testing/mochitest/runtests.py
@@ -23,16 +23,17 @@ import json
 import mozcrash
 import mozdebug
 import mozinfo
 import mozprocess
 import mozrunner
 import numbers
 import platform
 import re
+import shlex
 import shutil
 import signal
 import socket
 import subprocess
 import sys
 import tempfile
 import time
 import traceback
@@ -2217,17 +2218,17 @@ toolbar#nav-bar {
         if debuggerInfo:
             interactive = debuggerInfo.interactive
             debug_args = [debuggerInfo.path] + debuggerInfo.args
 
         # Set up Valgrind arguments.
         if valgrindPath:
             interactive = False
             valgrindArgs_split = ([] if valgrindArgs is None
-                                  else valgrindArgs.split(","))
+                                  else shlex.split(valgrindArgs))
 
             valgrindSuppFiles_final = []
             if valgrindSuppFiles is not None:
                 valgrindSuppFiles_final = ["--suppressions=" +
                                            path for path in valgrindSuppFiles.split(",")]
 
             debug_args = ([valgrindPath]
                           + mozdebug.get_default_valgrind_args()