Bug 1572936 - Flip `security.identityblock.show_extended_validation` to false to hide the ev indicators in the identity block. r=Gijs,whimboo
authorJohann Hofmann <jhofmann@mozilla.com>
Mon, 12 Aug 2019 14:11:45 +0000
changeset 487447 5b7489190e7842682201506d27d3f25ea94f8363
parent 487446 7dbe4c9716a7889ff95333ad0410e7bb2fa22318
child 487448 37bd619b82a9497ebfc8b031bbff1637c98bb812
push id36422
push usermalexandru@mozilla.com
push dateMon, 12 Aug 2019 21:51:10 +0000
treeherdermozilla-central@076dd880cd67 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, whimboo
bugs1572936
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1572936 - Flip `security.identityblock.show_extended_validation` to false to hide the ev indicators in the identity block. r=Gijs,whimboo Apparently this didn't have any tests other than the ones in functional-ui (of which one is disabled), but adding new ones for EV at the point where it's being disabled and eventually removed doesn't really make sense to me. Differential Revision: https://phabricator.services.mozilla.com/D41531
browser/app/profile/firefox.js
testing/firefox-ui/tests/functional/security/test_security_notification.py
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1368,17 +1368,17 @@ pref("security.insecure_field_warning.co
 pref("security.insecure_connection_icon.enabled", true);
 // Show degraded UI for http pages in private mode.
 pref("security.insecure_connection_icon.pbmode.enabled", true);
 
 // For secure connections, show gray instead of green lock icon
 pref("security.secure_connection_icon_color_gray", false);
 
 // Ignore EV certificate and treat as normal secure connection instead
-pref("security.identityblock.show_extended_validation", true);
+pref("security.identityblock.show_extended_validation", false);
 
 // Show "Not Secure" text for http pages; disabled for now
 pref("security.insecure_connection_text.enabled", false);
 pref("security.insecure_connection_text.pbmode.enabled", false);
 
 // 1 = allow MITM for certificate pinning checks.
 pref("security.cert_pinning.enforcement_level", 1);
 
--- a/testing/firefox-ui/tests/functional/security/test_security_notification.py
+++ b/testing/firefox-ui/tests/functional/security/test_security_notification.py
@@ -15,17 +15,17 @@ class TestSecurityNotification(Puppeteer
 
     def setUp(self):
         super(TestSecurityNotification, self).setUp()
 
         self.urls = [
             # Invalid cert page
             'https://expired.badssl.com',
             # Secure page
-            'https://extended-validation.badssl.com',
+            'https://badssl.com',
             # Insecure page
             'http://http.badssl.com'
         ]
 
         self.identity_box = self.browser.navbar.locationbar.identity_box
 
     def test_invalid_cert(self):
         with self.marionette.using_context('content'):
@@ -46,17 +46,17 @@ class TestSecurityNotification(Puppeteer
             # Verify the error code is correct
             self.assertIn('SEC_ERROR_EXPIRED_CERTIFICATE', text.get_property('textContent'))
 
     def test_secure_website(self):
         with self.marionette.using_context('content'):
             self.marionette.navigate(self.urls[1])
 
         Wait(self.marionette).until(lambda _: (
-            self.identity_box.get_property('className') == 'verifiedIdentity')
+            self.identity_box.get_property('className') == 'verifiedDomain')
         )
 
     def test_insecure_website(self):
         with self.marionette.using_context('content'):
             self.marionette.navigate(self.urls[2])
 
         Wait(self.marionette).until(lambda _: (
             self.identity_box.get_property('className') == 'notSecure')