Bug 1463615 [wpt PR 11110] - [tools] Enable additional linting rules, a=testonly
authorjugglinmike <mike@mikepennisi.com>
Wed, 06 Jun 2018 14:32:25 +0000
changeset 422133 59d0ee801ffad99e17a7e96d70ffa5e3020937c5
parent 422132 46ca86af6962ec2a4e5c86a23a769ee486e54fc1
child 422134 019681d3ab4fedcc78b4dc153ec2a778e9c091c1
push id34122
push userebalazs@mozilla.com
push dateMon, 11 Jun 2018 09:37:00 +0000
treeherdermozilla-central@9941eb8c3b29 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1463615, 11110
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1463615 [wpt PR 11110] - [tools] Enable additional linting rules, a=testonly Automatic update from web-platform-tests[tools] Disallow implicitly-imported bindings (#11110) -- wpt-commits: ba7899bed2060b262906c1f5f094ff65becc39dd wpt-pr: 11110
testing/web-platform/tests/tools/tox.ini
testing/web-platform/tests/tools/wpt/tox.ini
testing/web-platform/tests/tools/wptrunner/tox.ini
testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome_android.py
testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/parser.py
--- a/testing/web-platform/tests/tools/tox.ini
+++ b/testing/web-platform/tests/tools/tox.ini
@@ -35,15 +35,13 @@ select = E,W,F,N
 # E302: expected 2 blank lines, found 0
 # E303: too many blank lines (3)
 # E305: expected 2 blank lines after end of function or class
 # E402: module level import not at top of file
 # E731: do not assign a lambda expression, use a def
 # E901: SyntaxError or IndentationError
 # W601: .has_key() is deprecated, use ‘in’
 # F401: module imported but unused
-# F403: ‘from module import *’ used; unable to detect undefined names
-# F405: name may be undefined, or defined from star imports: module
 # N801: class names should use CapWords convention
 # N802: function name should be lowercase
-ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,F403,F405,N801,N802
+ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,N801,N802
 max-line-length = 141
 exclude = .tox,html5lib,third_party/py,third_party/pytest,third_party/funcsigs,third_party/attrs,third_party/pluggy/,pywebsocket,six,_venv,webencodings,wptserve/docs,wptserve/tests/functional/docroot/,wpt,wptrunner
--- a/testing/web-platform/tests/tools/wpt/tox.ini
+++ b/testing/web-platform/tests/tools/wpt/tox.ini
@@ -38,14 +38,12 @@ select = E,W,F,N
 # E302: expected 2 blank lines, found 0
 # E303: too many blank lines (3)
 # E305: expected 2 blank lines after end of function or class
 # E402: module level import not at top of file
 # E731: do not assign a lambda expression, use a def
 # E901: SyntaxError or IndentationError
 # W601: .has_key() is deprecated, use ‘in’
 # F401: module imported but unused
-# F403: ‘from module import *’ used; unable to detect undefined names
-# F405: name may be undefined, or defined from star imports: module
 # N801: class names should use CapWords convention
 # N802: function name should be lowercase
-ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,F403,F405,N801,N802
+ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,N801,N802
 max-line-length = 141
--- a/testing/web-platform/tests/tools/wptrunner/tox.ini
+++ b/testing/web-platform/tests/tools/wptrunner/tox.ini
@@ -48,14 +48,12 @@ select = E,W,F,N
 # E302: expected 2 blank lines, found 0
 # E303: too many blank lines (3)
 # E305: expected 2 blank lines after end of function or class
 # E402: module level import not at top of file
 # E731: do not assign a lambda expression, use a def
 # E901: SyntaxError or IndentationError
 # W601: .has_key() is deprecated, use ‘in’
 # F401: module imported but unused
-# F403: ‘from module import *’ used; unable to detect undefined names
-# F405: name may be undefined, or defined from star imports: module
 # N801: class names should use CapWords convention
 # N802: function name should be lowercase
-ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,F403,F405,N801,N802
+ignore = E128,E129,E221,E226,E231,E251,E265,E302,E303,E305,E402,E731,E901,W601,F401,N801,N802
 max-line-length = 141
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome_android.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/browsers/chrome_android.py
@@ -1,11 +1,10 @@
 import subprocess
 
-from ..config import *
 from .base import Browser, ExecutorBrowser, require_arg
 from ..webdriver_server import ChromeDriverServer
 from ..executors import executor_kwargs as base_executor_kwargs
 from ..executors.executorselenium import (SeleniumTestharnessExecutor,
                                           SeleniumRefTestExecutor)
 from ..executors.executorchrome import ChromeDriverWdspecExecutor
 
 
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/parser.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptmanifest/parser.py
@@ -12,17 +12,20 @@
 
 # TODO: keep comments in the tree
 
 from __future__ import unicode_literals
 
 import types
 from cStringIO import StringIO
 
-from node import *
+from node import (AtomNode, BinaryExpressionNode, BinaryOperatorNode,
+                  ConditionalNode, DataNode, IndexNode, KeyValueNode, ListNode,
+                  NumberNode, StringNode, UnaryExpressionNode,
+                  UnaryOperatorNode, ValueNode, VariableNode)
 
 
 class ParseError(Exception):
     def __init__(self, filename, line, detail):
         self.line = line
         self.filename = filename
         self.detail = detail
         self.message = "%s: %s line %s" % (self.detail, self.filename, self.line)