Bug 920317: Banner cuts off TopSitesPage. [r=margaret]
authorSriram Ramasubramanian <sriram@mozilla.com>
Thu, 26 Sep 2013 15:39:36 -0700
changeset 149089 5996743f47bfcfed3ceadfaf74d4c4dabccbf607
parent 149088 d39711d1bc60e3fa19a69d1e23efbbe5834b921a
child 149090 7acf8f426b9e05e5d52fbd43bfcbf809b31d29ab
push id25368
push userkwierso@gmail.com
push dateSat, 28 Sep 2013 03:32:42 +0000
treeherdermozilla-central@2f4397db1830 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs920317
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 920317: Banner cuts off TopSitesPage. [r=margaret]
b2g/config/emulator/config.json
b2g/config/emulator/releng-emulator.tt
mobile/android/base/resources/layout/home_top_sites_page.xml
--- a/mobile/android/base/resources/layout/home_top_sites_page.xml
+++ b/mobile/android/base/resources/layout/home_top_sites_page.xml
@@ -1,29 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
-<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
-              android:layout_width="fill_parent"
-              android:layout_height="fill_parent"
-              android:orientation="vertical">
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+             android:layout_width="fill_parent"
+             android:layout_height="fill_parent"
+             android:orientation="vertical">
 
     <org.mozilla.gecko.home.HomeListView
             android:id="@+id/list"
             style="@style/Widget.TopSitesListView"
             android:layout_width="fill_parent"
-            android:layout_height="0dp"
-            android:layout_weight="1"/>
+            android:layout_height="fill_parent"/>
 
     <org.mozilla.gecko.home.HomeBanner android:id="@+id/home_banner"
                                        style="@style/Widget.HomeBanner"
                                        android:layout_width="fill_parent"
                                        android:layout_height="@dimen/home_banner_height"
                                        android:background="@drawable/home_banner"
                                        android:layout_gravity="bottom"
                                        android:gravity="center_vertical"
                                        android:visibility="gone"
                                        android:clickable="true"
                                        android:focusable="true"/>
 
-</LinearLayout>
+</FrameLayout>