Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (more widget parts); r=roc
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 19 Jun 2012 23:28:45 -0400
changeset 97091 58f066791aa7640096b8cc7bb0ad4cd2bae34ece
parent 97090 666e228c06abf93e00619781ee4b644247b312f3
child 97092 803c17d3b0bd2d190ee12b49d72a1bbeaa37dd20
push id22957
push usermh@glandium.org
push dateWed, 20 Jun 2012 08:54:19 +0000
treeherdermozilla-central@c3190d715044 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersroc
bugs758992
milestone16.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (more widget parts); r=roc
widget/tests/TestAppShellSteadyState.cpp
--- a/widget/tests/TestAppShellSteadyState.cpp
+++ b/widget/tests/TestAppShellSteadyState.cpp
@@ -18,16 +18,17 @@
 #include "nsIURI.h"
 #include "nsIWebBrowserChrome.h"
 #include "nsIXULWindow.h"
 
 #include "nsAppShellCID.h"
 #include "nsIInterfaceRequestorUtils.h"
 #include "nsNetUtil.h"
 #include "nsThreadUtils.h"
+#include "mozilla/Attributes.h"
 
 #ifdef XP_WIN
 #include <windows.h>
 #endif
 
 using namespace mozilla;
 
 typedef void (*TestFunc)(nsIAppShell*);
@@ -153,17 +154,17 @@ public:
     if (NS_FAILED(NS_DispatchToCurrentThread(runnable))) {
       fail("Failed to dispatch next test runnable");
     }
 
     return NS_OK;
   }
 };
 
-class EventListener : public nsIDOMEventListener
+class EventListener MOZ_FINAL : public nsIDOMEventListener
 {
   nsCOMPtr<nsIAppShell> mAppShell;
 
   static nsIDOMWindowUtils* sWindowUtils;
   static nsIAppShell* sAppShell;
 
 public:
   NS_DECL_ISUPPORTS