Bug 1643661 Fix shell quoting with hg commands r=mtabara
authorSimon Fraser <sfraser@mozilla.com>
Fri, 05 Jun 2020 12:06:21 +0000
changeset 534125 58e98c4dbecb3c03e68ff1cd94002cb06844c4be
parent 534124 1a8d79d0832fed96b4df55d28afe3925f6d8414f
child 534126 9c1d646353b318e1fbd2c2dc112eccfdd0720f80
push id37483
push userapavel@mozilla.com
push dateFri, 05 Jun 2020 21:40:11 +0000
treeherdermozilla-central@dadc7312128e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmtabara
bugs1643661
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1643661 Fix shell quoting with hg commands r=mtabara shellcheck will moan about this, as it's potentially unsafe Differential Revision: https://phabricator.services.mozilla.com/D78486
taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh
taskcluster/docker/python-dependency-update/scripts/update_pipfiles.sh
--- a/taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh
+++ b/taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh
@@ -401,18 +401,18 @@ function update_remote_settings_attachme
 
 # Clones an hg repo
 function clone_repo {
   cd "${BASEDIR}"
   if [ ! -d "${REPODIR}" ]; then
     ${HG} robustcheckout --sharebase /tmp/hg-store -b default "${HGREPO}" "${REPODIR}"
   fi
 
-  ${HG} -R ${REPODIR} pull
-  ${HG} -R ${REPODIR} update -C default
+  ${HG} -R "${REPODIR}" pull
+  ${HG} -R "${REPODIR}" update -C default
 }
 
 # Copies new HSTS files in place, and commits them.
 function stage_hsts_files {
   cd "${BASEDIR}"
   cp -f "${BASEDIR}/${PRODUCT}/$(basename "${HSTS_PRELOAD_INC}")" "${REPODIR}/security/manager/ssl/"
 }
 
--- a/taskcluster/docker/python-dependency-update/scripts/update_pipfiles.sh
+++ b/taskcluster/docker/python-dependency-update/scripts/update_pipfiles.sh
@@ -25,18 +25,18 @@ HG="$(command -v hg)"
 # Clones an hg repo
 function clone_repo {
   cd "${BASEDIR}"
   if [ ! -d "${REPODIR}" ]; then
     CLONE_CMD="${HG} clone ${HGREPO} ${REPODIR}"
     ${CLONE_CMD}
   fi
 
-  ${HG} -R ${REPODIR} pull
-  ${HG} -R ${REPODIR} update -C default
+  ${HG} -R "${REPODIR}" pull
+  ${HG} -R "${REPODIR}" update -C default
 }
 
 # Push all pending commits to Phabricator
 function push_repo {
   cd "${REPODIR}"
   if [ ! -r "${HOME}/.arcrc" ]
   then
     return 1