Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
☠☠ backed out by d83d3b37c2b8 ☠ ☠
authorMike Conley <mconley@mozilla.com>
Fri, 07 Jun 2019 14:29:53 +0000
changeset 477843 57336967a6c75c6d7070bd4bba81e258977c709b
parent 477842 8adcacadd689cf9b85c2434ff1103f4ce6820fad
child 477844 b83fb79138d705ed334da3ae6cfd6c9a7d352cdd
push id36125
push userapavel@mozilla.com
push dateFri, 07 Jun 2019 22:00:07 +0000
treeherdermozilla-central@d820bbb356aa [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy, kmag
bugs1505909
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag Differential Revision: https://phabricator.services.mozilla.com/D33166
toolkit/mozapps/extensions/content/extensions.js
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -3326,23 +3326,16 @@ var gDetailView = {
         const parentContextMenuPopup = parentChromeWindow.document.getElementById("contentAreaContextMenu");
 
         // Override openPopupAtScreen on the dummy menupopup element, so that we can forward
         // "nsContextMenu.js openContextMenu"'s calls related to the extensions "options page"
         // context menu events.
         document.getElementById("contentAreaContextMenu").openPopupAtScreen = (...args) => {
           return parentContextMenuPopup.openPopupAtScreen(...args);
         };
-
-        // Subscribe a "contextmenu" listener to handle the context menus for the extension option page
-        // running in the extension process (the context menu will be handled only for extension running
-        // in OOP mode, but that's ok as it is the default on any platform that uses these extensions
-        // options pages).
-        browser.messageManager.addMessageListener(
-          "contextmenu", message => parentChromeWindow.openContextMenu(message));
       });
     } else {
       readyPromise = promiseEvent("load", browser, true);
     }
 
     stack.appendChild(browser);
     parentNode.appendChild(stack);