No bug: [diffoscope] Output an empty diff if the files do not differ; r=glandium
authorTom Prince <mozilla@hocat.ca>
Fri, 22 Mar 2019 13:23:23 +0000
changeset 465704 5643338d4df0f6ee00cfcb99ad82c9687c07a59c
parent 465703 01cdf8342a49c2e06728f15835217f9d23b25cb9
child 465705 8f3474b08474c4c1a6f8ea2af5f4d225a730b49b
push id35746
push usershindli@mozilla.com
push dateSat, 23 Mar 2019 09:46:24 +0000
treeherdermozilla-central@02b7484f316b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug: [diffoscope] Output an empty diff if the files do not differ; r=glandium Currently, if the files match and you try to look at the diff, you get { "reason": "file-missing-on-worker", "message": "Artifact \"public/diff.html\" not found at \"/builds/worker/diff.html\"" } which makes it hard to tell if there was an error generating a diff, or if the files matched. This changes things to ask diffoscope to always output a diff, to remedy that confusion. Differential Revision: https://phabricator.services.mozilla.com/D24316
taskcluster/ci/diffoscope/kind.yml
--- a/taskcluster/ci/diffoscope/kind.yml
+++ b/taskcluster/ci/diffoscope/kind.yml
@@ -18,16 +18,17 @@ transforms:
 # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=879003
 # That skips `objdump --disassemble --line-numbers` and falls back to
 # `objdump --disassemble`
 # Note: the .chk excludes are for files that are known to differ between
 # builds because they are signed with an ephemeral private key that is
 # generated for each build.
 job-defaults:
   args: >-
+    --output-empty
     --no-default-limits
     --max-page-size 100000000
     --max-page-diff-block-lines 10000
     --exclude-directory-metadata
     --exclude-command .--line-numbers
     --exclude **/*freeblpriv3.chk
     --exclude **/*nssdbm3.chk
     --exclude **/*softokn3.chk