Bug 1298722 followup: remove obsolete documentation about MOZ_MUST_USE annotations on StyleAnimationValue::UncomputeValue(). (no review, comment-only, DONTBUILD)
authorDaniel Holbert <dholbert@cs.stanford.edu>
Fri, 24 Mar 2017 11:45:18 -0700
changeset 349574 562b1c41685ea8e17b111d0a8fe85f7bf06d189f
parent 349573 6d5787a383e4a83f957f69fd36b8c68c9d813cdd
child 349575 3dd028775ffa2822a1d7d10f52aacc819d55ef21
push id31553
push userkwierso@gmail.com
push dateSat, 25 Mar 2017 00:17:38 +0000
treeherdermozilla-central@65b0ac174753 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1298722
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1298722 followup: remove obsolete documentation about MOZ_MUST_USE annotations on StyleAnimationValue::UncomputeValue(). (no review, comment-only, DONTBUILD) Originally, the patch for Bug 1298722 was not going to label these functions as MOZ_MUST_USE, and it added a brief code-comment to explain that. But then it did end up labeling them as MOZ_MUST_USE after all, in response to some review feedback. And it kept the now-incorrect comment around by accident, it seems. This followup just removes that incorrect comment. MozReview-Commit-ID: 2c35wQPzXRN
layout/style/StyleAnimationValue.h
--- a/layout/style/StyleAnimationValue.h
+++ b/layout/style/StyleAnimationValue.h
@@ -252,19 +252,16 @@ public:
    * The overload that takes an rvalue StyleAnimationValue reference
    * transfers ownership for some resources such that the |aComputedValue|
    * does not depend on the lifetime of |aSpecifiedValue|.
    *
    * @param aProperty      The property whose value we're uncomputing.
    * @param aComputedValue The computed value to be converted.
    * @param [out] aSpecifiedValue The resulting specified value.
    * @return true on success, false on failure.
-   *
-   * These functions are not MOZ_MUST_USE because failing to check the return
-   * value is common and reasonable.
    */
   static MOZ_MUST_USE bool
   UncomputeValue(nsCSSPropertyID aProperty,
                  const StyleAnimationValue& aComputedValue,
                  nsCSSValue& aSpecifiedValue);
   static MOZ_MUST_USE bool
   UncomputeValue(nsCSSPropertyID aProperty,
                  StyleAnimationValue&& aComputedValue,