Bug 808410 - checkForCrashes should return true for cases where we hit an exception during minidump stackwalk; r=jmaher
authorEd Morley <emorley@mozilla.com>
Tue, 20 Nov 2012 15:24:28 +0000
changeset 113778 55ea556dffb9d3fbaa489e8a6e7984d2e6645492
parent 113777 0ed85ba08942d771fbe1049421ddaf6d4386e964
child 113779 966b4616dfac55f5fd6910206bc7fe555fea7936
push id23890
push userryanvm@gmail.com
push dateWed, 21 Nov 2012 02:43:32 +0000
treeherdermozilla-central@4f19e7fd8bea [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs808410
milestone20.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 808410 - checkForCrashes should return true for cases where we hit an exception during minidump stackwalk; r=jmaher
build/automationutils.py
--- a/build/automationutils.py
+++ b/build/automationutils.py
@@ -141,17 +141,16 @@ def checkForCrashes(dumpDir, symbolsPath
     except:
       testName = "unknown"
 
   # Check preconditions
   dumps = glob.glob(os.path.join(dumpDir, '*.dmp'))
   if len(dumps) == 0:
     return False
 
-  foundCrash = False
   removeSymbolsPath = False
 
   # If our symbols are at a remote URL, download them now
   if symbolsPath and isURL(symbolsPath):
     print "Downloading symbols from: " + symbolsPath
     removeSymbolsPath = True
     # Get the symbols and write them to a temporary zipfile
     data = urllib2.urlopen(symbolsPath)
@@ -193,22 +192,21 @@ def checkForCrashes(dumpDir, symbolsPath
         shutil.move(d, dumpSavePath)
         print "Saved dump as %s" % os.path.join(dumpSavePath,
                                                 os.path.basename(d))
       else:
         os.remove(d)
       extra = os.path.splitext(d)[0] + ".extra"
       if os.path.exists(extra):
         os.remove(extra)
-      foundCrash = True
   finally:
     if removeSymbolsPath:
       shutil.rmtree(symbolsPath)
 
-  return foundCrash
+  return True
 
 def getFullPath(directory, path):
   "Get an absolute path relative to 'directory'."
   return os.path.normpath(os.path.join(directory, os.path.expanduser(path)))
 
 def searchPath(directory, path):
   "Go one step beyond getFullPath and try the various folders in PATH"
   # Try looking in the current working directory first.