Bug 1295831 - VIDEO_INTER_KEYFRAME_MAX_MS==0 means only 1 keyframe - r=francois
authorGerald Squelart <gsquelart@mozilla.com>
Thu, 18 Aug 2016 11:58:44 +1000
changeset 309978 5576171f46151b38996fc96ff150ef311ddcc387
parent 309977 987a4d3e9f0d0a1722a35e28c2873f1396b691c3
child 309979 c592e44da5f31eeaca861e6e1af75b6ed2c9fe59
push id30575
push userryanvm@gmail.com
push dateFri, 19 Aug 2016 13:46:06 +0000
treeherdermozilla-central@3da4d64410c0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfrancois
bugs1295831
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1295831 - VIDEO_INTER_KEYFRAME_MAX_MS==0 means only 1 keyframe - r=francois Telemetry peer review through mozreview. This patch is modifying this probe description sligthly, to add the collection of a special value: '0' means that only one keyframe was found when playing a video (played for at least enough time to be eligible for video-decode-suspend feature.) Please note that this will not modify existing data or their meaning: It will just add this zero value (which is not otherwise possible or meaningful when dealing with *inter-keyframe* timings), which will help gauge the relative presence of these difficult-to-recover-from videos, compared to more "normal" videos. MozReview-Commit-ID: ANFtybW9BKu
toolkit/components/telemetry/Histograms.json
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -8111,17 +8111,17 @@
     "kind": "exponential",
     "high": 60000,
     "n_buckets": 100,
     "bug_numbers": [1289668]
   },
   "VIDEO_INTER_KEYFRAME_MAX_MS" : {
     "alert_emails": ["ajones@mozilla.com", "gsquelart@mozilla.com"],
     "expires_in_version": "55",
-    "description": "Maximum interval between video keyframes in played videos, in milliseconds. Keyed by audio presence and by height ranges (boundaries: 240. 480, 576, 720, 1080, 2160), e.g.: 'V,0<h<=240', 'AV,h>2160'; and 'All' will accumulate all percentages. This is reported whenever an HTML Media Element is suspended or resumed, such as when the page is unloaded.",
+    "description": "Maximum interval between video keyframes in played videos, in milliseconds; '0' means only 1 keyframe found. Keyed by audio presence and by height ranges (boundaries: 240. 480, 576, 720, 1080, 2160), e.g.: 'V,0<h<=240', 'AV,h>2160'; and 'All' will accumulate all percentages. This is reported whenever an HTML Media Element is suspended or resumed, such as when the page is unloaded.",
     "keyed": true,
     "kind": "exponential",
     "high": 60000,
     "n_buckets": 100,
     "bug_numbers": [1289668]
   },
   "VIDEO_SUSPEND_RECOVERY_TIME_MS" : {
     "alert_emails": ["ajones@mozilla.com", "gsquelart@mozilla.com"],