☠☠ backed out by c91db7615094 ☠ ☠ | |
author | Dão Gottwald <dao@mozilla.com> |
Tue, 09 May 2017 15:56:20 +0200 | |
changeset 357230 | 553198d4b70fef266094ba0e397dee72b429b61c |
parent 357229 | 2ca07f25550d45756a17bb2e885a0139f4f73534 |
child 357231 | d813ff0d21b5baecd7f0b827973e3fe98d312942 |
push id | 31788 |
push user | kwierso@gmail.com |
push date | Tue, 09 May 2017 20:48:49 +0000 |
treeherder | mozilla-central@2b6f6881a24a [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | Gijs |
bugs | 1363118 |
milestone | 55.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
browser/app/profile/firefox.js | file | annotate | diff | comparison | revisions | |
browser/components/nsBrowserGlue.js | file | annotate | diff | comparison | revisions |
--- a/browser/app/profile/firefox.js +++ b/browser/app/profile/firefox.js @@ -233,17 +233,17 @@ pref("general.autoScroll", true); pref("browser.shell.checkDefaultBrowser", true); pref("browser.shell.shortcutFavicons",true); pref("browser.shell.mostRecentDateSetAsDefault", ""); #ifdef RELEASE_OR_BETA pref("browser.shell.skipDefaultBrowserCheckOnFirstRun", false); #else pref("browser.shell.skipDefaultBrowserCheckOnFirstRun", true); #endif -pref("browser.shell.skipDefaultBrowserCheck", true); +pref("browser.shell.didSkipDefaultBrowserCheckOnFirstRun", false); pref("browser.shell.defaultBrowserCheckCount", 0); pref("browser.defaultbrowser.notificationbar", false); // 0 = blank, 1 = home (browser.startup.homepage), 2 = last visited page, 3 = resume previous browser session // The behavior of option 3 is detailed at: http://wiki.mozilla.org/Session_Restore pref("browser.startup.page", 1); pref("browser.startup.homepage", "chrome://branding/locale/browserconfig.properties"); // Whether we should skip the homepage when opening the first-run page
--- a/browser/components/nsBrowserGlue.js +++ b/browser/components/nsBrowserGlue.js @@ -1065,17 +1065,17 @@ BrowserGlue.prototype = { // Perform default browser checking. if (ShellService) { let shouldCheck = AppConstants.DEBUG ? false : ShellService.shouldCheckDefaultBrowser; const skipDefaultBrowserCheck = Services.prefs.getBoolPref("browser.shell.skipDefaultBrowserCheckOnFirstRun") && - Services.prefs.getBoolPref("browser.shell.skipDefaultBrowserCheck"); + !Services.prefs.getBoolPref("browser.shell.didSkipDefaultBrowserCheckOnFirstRun"); const usePromptLimit = !AppConstants.RELEASE_OR_BETA; let promptCount = usePromptLimit ? Services.prefs.getIntPref("browser.shell.defaultBrowserCheckCount") : 0; let willRecoverSession = false; try { let ss = Cc["@mozilla.org/browser/sessionstartup;1"]. @@ -1099,17 +1099,17 @@ BrowserGlue.prototype = { } let willPrompt = shouldCheck && !isDefault && !willRecoverSession; // Skip the "Set Default Browser" check during first-run or after the // browser has been run a few times. if (willPrompt) { if (skipDefaultBrowserCheck) { - Services.prefs.setBoolPref("browser.shell.skipDefaultBrowserCheck", false); + Services.prefs.setBoolPref("browser.shell.didSkipDefaultBrowserCheckOnFirstRun", true); willPrompt = false; } else { promptCount++; } if (usePromptLimit && promptCount > 3) { willPrompt = false; } } @@ -1662,17 +1662,17 @@ BrowserGlue.prototype = { if (topic != "alertclickcallback") return; this._openPreferences("sync"); } AlertsService.showAlertNotification(null, title, body, true, null, clickCallback); }, _migrateUI: function BG__migrateUI() { - const UI_VERSION = 44; + const UI_VERSION = 45; const BROWSER_DOCURL = "chrome://browser/content/browser.xul"; let currentUIVersion; if (Services.prefs.prefHasUserValue("browser.migration.version")) { currentUIVersion = Services.prefs.getIntPref("browser.migration.version"); } else { // This is a new profile, nothing to migrate. Services.prefs.setIntPref("browser.migration.version", UI_VERSION); @@ -1956,16 +1956,23 @@ BrowserGlue.prototype = { Services.prefs.setBoolPref("toolkit.cosmeticAnimations.enabled", animate); Services.prefs.clearUserPref("browser.tabs.animate"); Services.prefs.clearUserPref("browser.fullscreen.animate"); Services.prefs.clearUserPref("alerts.disableSlidingEffect"); } + if (currentUIVersion < 45) { + const LEGACY_PREF = "browser.shell.skipDefaultBrowserCheck"; + Services.prefs.setBoolPref("browser.shell.didSkipDefaultBrowserCheckOnFirstRun", + !Services.prefs.getBoolPref(LEGACY_PREF)); + Services.prefs.clearUserPref(LEGACY_PREF); + } + // Update the migration version. Services.prefs.setIntPref("browser.migration.version", UI_VERSION); }, // ------------------------------ // public nsIBrowserGlue members // ------------------------------