Bug 1452143: Don't test content CSS error reporting in the browser console. r=jryans
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 16 Apr 2018 16:29:38 +0200
changeset 414082 5520fcaf93d2c53d2348831451af20ca0999ff87
parent 414081 6b3425746bfdd30f900ebda6b7419d551ad54ac3
child 414083 7b130a4f638a17f5cea2aec8abd14e48aee67d86
push id33858
push userncsoregi@mozilla.com
push dateTue, 17 Apr 2018 21:55:44 +0000
treeherdermozilla-central@d6eb5597d744 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjryans
bugs1452143
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1452143: Don't test content CSS error reporting in the browser console. r=jryans The browser console doesn't enable the cssErrorReportingEnabled bit on the content process remote windows, and making it work seems non-trivial and kinda useless per the firefox-dev@ discussions. So just remove this test. MozReview-Commit-ID: GMGuQC7YNof
devtools/client/webconsole/test/mochitest/browser_console_error_source_click.js
--- a/devtools/client/webconsole/test/mochitest/browser_console_error_source_click.js
+++ b/devtools/client/webconsole/test/mochitest/browser_console_error_source_click.js
@@ -4,46 +4,38 @@
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 // Check that JS errors and CSS warnings open view source when their source link
 // is clicked in the Browser Console.
 
 "use strict";
 
 const TEST_URI = "data:text/html;charset=utf8,<p>hello world" +
-                 "<button onclick='foobar.explode()' " +
-                 "style='test-color: green-please'>click!</button>";
+                 "<button onclick='foobar.explode()'>click!</button>";
 
 add_task(async function() {
   await addTab(TEST_URI);
+
   let hud = await HUDService.toggleBrowserConsole();
   ok(hud, "browser console opened");
 
-  // Enable CSS warnings and errors.
-  await setFilterState(hud, {
-    css: true
-  });
-
   // On e10s, the exception is triggered in child process
   // and is ignored by test harness
   if (!Services.appinfo.browserTabsRemoteAutostart) {
     expectUncaughtException();
   }
 
   info("generate exception and wait for the message");
   ContentTask.spawn(gBrowser.selectedBrowser, {}, () => {
     let button = content.document.querySelector("button");
     button.click();
   });
 
   await waitForMessageAndViewSource(hud,
     "ReferenceError: foobar is not defined");
-  await waitForMessageAndViewSource(hud,
-    "Unknown property \u2018test-color\u2019.");
-  await resetFilters(hud);
 });
 
 async function waitForMessageAndViewSource(hud, message) {
   let msg = await waitFor(() => findMessage(hud, message));
   ok(msg, `Message found: "${message}"`);
 
   let locationNode = msg.querySelector(".message-location .frame-link-source");
   ok(locationNode, "Message location link element found");