Bug 842828: Mark attributes of nsIApplicationReputationQuery as readonly, remove unused field (r=mossop)
☠☠ backed out by 2ac30931b19b ☠ ☠
authorMonica Chew <mmc@mozilla.com>
Wed, 25 Sep 2013 07:03:42 -0700
changeset 148673 550e2f5b42246ea41f8cf28eff4b71541cfee8cf
parent 148672 bb76828c5f22e236f848fa7df7aacd0b58522315
child 148674 af0dda676cb795cbc6509d74ae1faf604fcebcbc
push id25352
push userkwierso@gmail.com
push dateThu, 26 Sep 2013 03:27:24 +0000
treeherdermozilla-central@94548c13fd47 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs842828
milestone27.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 842828: Mark attributes of nsIApplicationReputationQuery as readonly, remove unused field (r=mossop)
toolkit/components/downloads/nsIApplicationReputation.idl
--- a/toolkit/components/downloads/nsIApplicationReputation.idl
+++ b/toolkit/components/downloads/nsIApplicationReputation.idl
@@ -38,47 +38,42 @@ interface nsIApplicationReputationServic
                        in nsIApplicationReputationCallback aCallback);
 };
 
 /**
  * A single-use, write-once interface for recording the metadata of the
  * downloaded file. nsIApplicationReputationService.Start() may only be called
  * once with a single query.
  */
-[scriptable, uuid(857da2c0-cfe5-11e2-8b8b-0800200c9a66)]
+[scriptable, uuid(5a054991-e489-4a1c-a0aa-ea7c69b20e3d)]
 interface nsIApplicationReputationQuery : nsISupports {
   /*
    * The nsIURI from which the file was downloaded. This may not be null.
    */
-  attribute nsIURI sourceURI;
+  readonly attribute nsIURI sourceURI;
 
   /*
    * The target filename for the downloaded file, as inferred from the source
    * URI or provided by the Content-Disposition attachment file name. If this
    * is not set by the caller, it will be passed as an empty string but the
    * query won't produce any useful information.
    */
-  attribute AString suggestedFileName;
+  readonly attribute AString suggestedFileName;
 
   /*
    * The size of the downloaded file in bytes.
    */
-  attribute unsigned long fileSize;
+  readonly attribute unsigned long fileSize;
 
   /*
    * The SHA256 hash of the downloaded file in raw bytes. If this is not set by
    * the caller, it will be passed as an empty string but the query won't
    * produce any useful information.
    */
-  attribute ACString sha256Hash;
-
-  /**
-   * The callback object listening to this query.
-   */
-  attribute nsIApplicationReputationCallback callback;
+  readonly attribute ACString sha256Hash;
 };
 
 [scriptable, function, uuid(9a228470-cfe5-11e2-8b8b-0800200c9a66)]
 interface nsIApplicationReputationCallback : nsISupports {
   /**
    * Callback for the result of the application reputation query.
    * @param aStatus
    *        NS_OK if and only if the query succeeded. If it did, then