Bug 1550893 - Fix the implicit builtinclassness for some Windows widget interfaces. r=bobowen
authorAndrew McCreight <continuation@gmail.com>
Tue, 14 May 2019 08:19:10 +0000
changeset 473789 54a4320c7206d6a478b23a6a52b1f51b00dcec53
parent 473788 7d2d7b47ec349aa71ab0a49a18cfced4b92b7189
child 473790 4934e59477f4d9cb7ab742973b4c31ee3b9bd261
push id36015
push usercbrindusan@mozilla.com
push dateTue, 14 May 2019 21:40:04 +0000
treeherdermozilla-central@f17162f343b6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen
bugs1550893
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550893 - Fix the implicit builtinclassness for some Windows widget interfaces. r=bobowen nsITaskbarTabPreview has a notxpcom method, so it has always been treated as builtinclass. This just makes it explicit. The same thing is true for nsIPrintSettingsWin, but as far as I can tell it is never actually used from JS, so I just removed the scriptable tag. Differential Revision: https://phabricator.services.mozilla.com/D30981
widget/nsIPrintSettingsWin.idl
widget/nsITaskbarTabPreview.idl
--- a/widget/nsIPrintSettingsWin.idl
+++ b/widget/nsIPrintSettingsWin.idl
@@ -13,17 +13,17 @@
  * Native types
  */
   [ptr] native nsDevMode(DEVMODEW);
   native nsHdc(HDC);
 
 /**
  * Simplified PrintSettings for Windows interface
  */
-[scriptable, uuid(c63eed41-6ac5-459e-8a64-033eb9ad770a)]
+[uuid(c63eed41-6ac5-459e-8a64-033eb9ad770a)]
 interface nsIPrintSettingsWin : nsISupports
 {
   /**
    * Data Members
    *
    * Each of these data members make a copy
    * of the contents. If you get the value,
    * you own the memory.
--- a/widget/nsITaskbarTabPreview.idl
+++ b/widget/nsITaskbarTabPreview.idl
@@ -15,17 +15,17 @@ interface imgIContainer;
  * nsITaskbarTabPreview for a window will hide that window's
  * nsITaskbarWindowPreview in the taskbar - the native API performs this
  * unconditionally. When there are no more tab previews for a window, the
  * nsITaskbarWindowPreview will automatically become visible again.
  *
  * An application may have as many tab previews per window as memory allows.
  *
  */
-[scriptable, uuid(11E4C8BD-5C2D-4E1A-A9A1-79DD5B0FE544)]
+[scriptable, builtinclass, uuid(11E4C8BD-5C2D-4E1A-A9A1-79DD5B0FE544)]
 interface nsITaskbarTabPreview : nsITaskbarPreview
 {
   /**
    * The title displayed above the thumbnail
    *
    * Default: an empty string
    */
   attribute AString title;