Bug 1526737 - Enable moz2d's NEON even if windows/aarch64. r=jrmuizel,dmajor
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Tue, 12 Feb 2019 16:21:26 +0000
changeset 458845 547cbfca4507
parent 458844 6d9b468951ce
child 458846 bc69bea83b66
push id35548
push useropoprus@mozilla.com
push dateWed, 13 Feb 2019 09:48:26 +0000
treeherdermozilla-central@93e37c529818 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel, dmajor
bugs1526737, 1516062
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526737 - Enable moz2d's NEON even if windows/aarch64. r=jrmuizel,dmajor Bug 1516062 turns on NEON when using gcc and clang. But windows compiler uses clang-cl, so I would like to turn on it even if windows. Differential Revision: https://phabricator.services.mozilla.com/D19281
gfx/2d/moz.build
--- a/gfx/2d/moz.build
+++ b/gfx/2d/moz.build
@@ -217,18 +217,17 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'coco
     EXPORTS.mozilla.gfx += [
         'QuartzSupport.h',
     ]
     SOURCES += [
         'MacIOSurface.cpp',
         'QuartzSupport.mm',
     ]
 
-if CONFIG['CC_TYPE'] in ('clang', 'gcc') and (CONFIG['CPU_ARCH'] == 'aarch64' or CONFIG['BUILD_ARM_NEON']):
-    # MSVC cannot use arm_neon.h.
+if CONFIG['CC_TYPE'] in ('clang', 'clang-cl', 'gcc') and (CONFIG['CPU_ARCH'] == 'aarch64' or CONFIG['BUILD_ARM_NEON']):
     SOURCES += [
         'BlurNEON.cpp',
         'LuminanceNEON.cpp',
         'SwizzleNEON.cpp',
     ]
     DEFINES['USE_NEON'] = True
     SOURCES['BlurNEON.cpp'].flags += CONFIG['NEON_FLAGS']
     SOURCES['LuminanceNEON.cpp'].flags += CONFIG['NEON_FLAGS']