Bug 1618260 - Remove an unused whitelist item in browser_parsable_css.js.
authorEmilio Cobos Álvarez <emilio@crisal.io>
Wed, 18 Mar 2020 13:19:06 +0100
changeset 519352 546c90bb0b043b421cba412ce3d251f3cb4023ce
parent 519351 a5ce9219be07e51e60df53571ab43e0daa5b00ec
child 519353 4c82ec92ccea077c6fb88132081399eb486fcfe1
push id37225
push userdvarga@mozilla.com
push dateWed, 18 Mar 2020 16:05:52 +0000
treeherdermozilla-central@5bfecf5aff6d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1618260
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1618260 - Remove an unused whitelist item in browser_parsable_css.js. Now we don't get to parse that declaration because it's inside a block with an internal selector. CLOSED TREE MANUAL PUSH: Test is skipped on debug builds so I missed it from my try push.
browser/base/content/test/static/browser_parsable_css.js
--- a/browser/base/content/test/static/browser_parsable_css.js
+++ b/browser/base/content/test/static/browser_parsable_css.js
@@ -84,29 +84,16 @@ if (
   // These are UA sheets which use non-content-exposed `display` values.
   whitelist.push({
     sourceName: /(skin\/shared\/Heartbeat|((?:res|gre-resources)\/(ua|html)))\.css$/i,
     errorMessage: /Error in parsing value for .*\bdisplay\b/i,
     isFromDevTools: false,
   });
 }
 
-if (
-  !Services.prefs.getBoolPref(
-    "layout.css.line-height-moz-block-height.content.enabled"
-  )
-) {
-  // -moz-block-height is used in form controls but not exposed to the web.
-  whitelist.push({
-    sourceName: /(?:res|gre-resources)\/forms\.css$/i,
-    errorMessage: /Error in parsing value for \u2018line-height\u2019/iu,
-    isFromDevTools: false,
-  });
-}
-
 if (!Services.prefs.getBoolPref("layout.css.scrollbar-width.enabled")) {
   whitelist.push({
     sourceName: /(?:res|gre-resources)\/forms\.css$/i,
     errorMessage: /Unknown property .*\bscrollbar-width\b/i,
     isFromDevTools: false,
   });
 }