Bug 701348 - qcms_transform_precacheLUT_float did not properly free dest buffer. r=jmuizelaar
authorBenoit Girard <b56girard@gmail.com>
Thu, 10 Nov 2011 08:28:58 -0500
changeset 80334 54232f15f953c61970baf92a580478dfb9168407
parent 80333 831f0b92c1828513d82e2b636b21ee5d6d174ea7
child 80335 666ba50edd30d23c3615c252ee0e4977b769582f
push id21485
push userbmo@edmorley.co.uk
push dateWed, 16 Nov 2011 11:04:25 +0000
treeherdermozilla-central@30161b298513 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmuizelaar
bugs701348
milestone11.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 701348 - qcms_transform_precacheLUT_float did not properly free dest buffer. r=jmuizelaar
gfx/qcms/transform.c
--- a/gfx/qcms/transform.c
+++ b/gfx/qcms/transform.c
@@ -1073,17 +1073,18 @@ qcms_transform* qcms_transform_precacheL
 			}
 		}
 	}
 
 
 	//XXX: qcms_modular_transform_data may return either the src or dest buffer. If so it must not be free-ed
 	if (src && lut != src) {
 		free(src);
-	} else if (dest && lut != src) {
+	}
+	if (dest && lut != dest) {
 		free(dest);
 	}
 
 	if (lut == NULL) {
 		return NULL;
 	}
 	return transform;
 }