Bug 1300663 - Catch HTTPError when query for symbols url. r=jlund
authorArmen Zambrano Gasparnian <armenzg@mozilla.com>
Fri, 23 Sep 2016 13:37:58 -0400
changeset 315259 5388505dd76ad12aee4efc8db531a9aca3e90a0b
parent 315258 6a20fed1e0791573c75556fa42605cec5048cff5
child 315260 b0a1038a579781d2e50a468948647eecd2a2cfc2
push id30745
push usercbook@mozilla.com
push dateTue, 27 Sep 2016 09:18:23 +0000
treeherdermozilla-central@7b050ca8ec64 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjlund
bugs1300663
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1300663 - Catch HTTPError when query for symbols url. r=jlund If we don't catch HTTPError, the whole job fails since we get an uncaught exception. MozReview-Commit-ID: 8jwW7ZSieyC
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -194,17 +194,17 @@ class TestingMixin(VirtualenvMixin, Buil
         elif self.installer_url:
             symbols_url = self.query_prefixed_build_dir_url('.crashreporter-symbols.zip')
 
             # Check if the URL exists. If not, use none to allow mozcrash to auto-check for symbols
             try:
                 if symbols_url:
                     self._urlopen(symbols_url, timeout=120)
                     self.symbols_url = symbols_url
-            except (urllib2.URLError, socket.error, socket.timeout):
+            except (urllib2.HTTPError, urllib2.URLError, socket.error, socket.timeout):
                 self.exception("Can't figure out symbols_url from installer_url: %s!" % self.installer_url, level=WARNING)
 
         # If no symbols URL can be determined let minidump_stackwalk query the symbols.
         # As of now this only works for Nightly and release builds.
         if not self.symbols_url:
             self.warning("No symbols_url found. Let minidump_stackwalk query for symbols.")
 
         return self.symbols_url