Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer
authorFred Lin <gasolin@gmail.com>
Tue, 21 Nov 2017 13:12:56 +0800
changeset 393036 5378dcb45044a160fad93b02eed0c617f3324dbc
parent 393035 931eb8bca980a9b603c616f41e5b181fc8e0bdfb
child 393037 05a913c5cf3f9f9577d103352c6a593b8fa4fd60
child 393045 7ca94f459acf231f774d3db2e7f8d0d1d4a8e0bb
child 393152 b02047ad5ee7326788bbb8143bc1cf1b7d7a5e72
push id32947
push useraciure@mozilla.com
push dateWed, 22 Nov 2017 09:57:59 +0000
treeherdermozilla-central@5378dcb45044 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersFischer
bugs1418191
milestone59.0a1
first release with
nightly linux32
5378dcb45044 / 59.0a1 / 20171122103138 / files
nightly linux64
5378dcb45044 / 59.0a1 / 20171122103138 / files
nightly mac
5378dcb45044 / 59.0a1 / 20171122103138 / files
nightly win32
5378dcb45044 / 59.0a1 / 20171122103138 / files
nightly win64
5378dcb45044 / 59.0a1 / 20171122103138 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer MozReview-Commit-ID: 9KJazfZqviT
browser/extensions/onboarding/content/onboarding.js
--- a/browser/extensions/onboarding/content/onboarding.js
+++ b/browser/extensions/onboarding/content/onboarding.js
@@ -815,22 +815,16 @@ class Onboarding {
           event: "overlay-nav-click",
           tour_id: tourId,
           session_key: this._session_key,
         });
 
         // Some tours should complete instantly upon showing.
         if (tab.getAttribute("data-instant-complete")) {
           this.setToursCompleted([tourId]);
-          // Also track auto-completed tour so we can filter data with the same event.
-          telemetry({
-            event: "overlay-cta-click",
-            tour_id: tourId,
-            session_key: this._session_key,
-          });
         }
       } else {
         tab.classList.remove("onboarding-active");
         tab.setAttribute("aria-selected", false);
       }
     }
   }