Bug 1643270 - Isolate headers panel treeview css changes r=Honza
authorHubert Boma Manilla <hmanilla@mozilla.com>
Sat, 06 Jun 2020 06:47:00 +0000
changeset 534255 535035537a93be3ab8b9a37512a3bcd4c571842c
parent 534254 f585b6b1a1984e87a99ad8e0f263d63d2ccde8e6
child 534256 f5309db93bc0b3aa8d566e2c8b5f7c0060e14790
push id37485
push userrmaries@mozilla.com
push dateSat, 06 Jun 2020 21:47:44 +0000
treeherdermozilla-central@69f8ba80bb41 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersHonza
bugs1643270, 1643296
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1643270 - Isolate headers panel treeview css changes r=Honza - Fixes Bug 1643270 with unexpandale nodes - Fixes Bug 1643296 so clicking any part of the method cllapses the node Differential Revision: https://phabricator.services.mozilla.com/D78254
devtools/client/netmonitor/src/assets/styles/HeadersPanel.css
devtools/client/netmonitor/src/assets/styles/UrlPreview.css
devtools/client/netmonitor/test/browser_net_params_sorted.js
--- a/devtools/client/netmonitor/src/assets/styles/HeadersPanel.css
+++ b/devtools/client/netmonitor/src/assets/styles/HeadersPanel.css
@@ -122,35 +122,35 @@
   margin-inline-end: 2px;
 }
 
 .network-monitor .headers-summary .status-text {
   width: auto !important;
   margin-inline-start: 4px;
 }
 
-.network-monitor .accordion .properties-view tr.treeRow {
+.network-monitor .headers-panel-container .accordion .properties-view tr.treeRow {
   padding: 3px 0 0 0;
 }
-.network-monitor .accordion .properties-view tr.treeRow .treeLabelCell {
+.network-monitor .headers-panel-container .accordion .properties-view tr.treeRow .treeLabelCell {
   float: left;
   margin-right: -33px;
   margin-left: 5px;
   padding: 0;
   
 }
-.network-monitor .accordion .properties-view tr.treeRow .treeValueCell {
+.network-monitor .headers-panel-container .accordion .properties-view tr.treeRow .treeValueCell {
   display: inline;
   word-break: break-all;
   box-decoration-break: clone;
   padding-left: 39px;
   padding-right: 20px;
 }
 
-.network-monitor .accordion .properties-view tr.treeRow .treeValueCell div {
+.network-monitor .headers-panel-container .accordion .properties-view tr.treeRow .treeValueCell div {
   display: inline;
 }
 
 /* Summary tabpanel */
 
 .network-monitor .tabpanel-summary-container {
   flex-wrap: wrap;
   padding-inline-start: 4px;
--- a/devtools/client/netmonitor/src/assets/styles/UrlPreview.css
+++ b/devtools/client/netmonitor/src/assets/styles/UrlPreview.css
@@ -70,25 +70,25 @@
 .url-preview tr.treeRow:first-child .treeLabelCell {
   font-weight: bold;
   color: var(--theme-icon-dimmed-color);
 }
 
 .url-preview tr.treeRow .treeLabelCell {
   float: left;
   margin-right: -15px;
-  padding: 0;
-  
+  padding: 0 2px 0 0;
+
 }
 .url-preview tr.treeRow .treeValueCell {
   display: inline;
   word-break: break-all;
   max-width: none;
   box-decoration-break: clone;
-  padding-left: 20px;
+  margin-left: 14px;
 }
 
 .url-preview .treeTable .treeValueCell {
   color: var(--theme-body-color);
 }
 
 .url-preview .url-scheme,
 .url-preview .url-chars {
--- a/devtools/client/netmonitor/test/browser_net_params_sorted.js
+++ b/devtools/client/netmonitor/test/browser_net_params_sorted.js
@@ -44,28 +44,28 @@ add_task(async function() {
   //     ▼ 4: {…}
   //         a: 10
   //       ▼ b: […]
   //           0: "a"
   //           1: "c"
   //           2: "b"
   //         c: 15
   const expectedKeys = [
-    "watches\n[…]",
-    `0\n"hello"`,
-    `1\n"how"`,
-    `2\n"are"`,
-    `3\n"you"`,
-    "4\n{…}",
-    "a\n10",
-    "b\n[…]",
-    `0\n"a"`,
-    `1\n"c"`,
-    `2\n"b"`,
-    "c\n15",
+    "watches\t[…]",
+    `0\t"hello"`,
+    `1\t"how"`,
+    `2\t"are"`,
+    `3\t"you"`,
+    "4\t{…}",
+    "a\t10",
+    "b\t[…]",
+    `0\t"a"`,
+    `1\t"c"`,
+    `2\t"b"`,
+    "c\t15",
   ];
 
   const waitForTreeRow = waitForDOM(
     document,
     ".treeTable .treeRow",
     expectedKeys.length
   );
   await waitForTreeRow;