Bug 1405993 - Part 1: Don't report warnings for sprintf calls in ICU. r=mystor
authorAndré Bargull <andre.bargull@gmail.com>
Wed, 01 Nov 2017 11:47:59 -0700
changeset 391986 53015dab607555789926343c75a478f10337df0b
parent 391985 815b8640da1e3029dd680e4187b68852d36e2a4e
child 391987 d6daf71433d29c79dd89b8251d647826b45fab65
push id32909
push usercbrindusan@mozilla.com
push dateWed, 15 Nov 2017 22:25:14 +0000
treeherdermozilla-central@f41930a869a8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmystor
bugs1405993
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1405993 - Part 1: Don't report warnings for sprintf calls in ICU. r=mystor
build/clang-plugin/Utils.h
--- a/build/clang-plugin/Utils.h
+++ b/build/clang-plugin/Utils.h
@@ -238,16 +238,17 @@ inline bool isIgnoredPathForSprintfLiter
                                     End = llvm::sys::path::rend(FileName);
   for (; Begin != End; ++Begin) {
     if (Begin->compare_lower(StringRef("angle")) == 0 ||
         Begin->compare_lower(StringRef("chromium")) == 0 ||
         Begin->compare_lower(StringRef("crashreporter")) == 0 ||
         Begin->compare_lower(StringRef("google-breakpad")) == 0 ||
         Begin->compare_lower(StringRef("gflags")) == 0 ||
         Begin->compare_lower(StringRef("harfbuzz")) == 0 ||
+        Begin->compare_lower(StringRef("icu")) == 0 ||
         Begin->compare_lower(StringRef("jsoncpp")) == 0 ||
         Begin->compare_lower(StringRef("libstagefright")) == 0 ||
         Begin->compare_lower(StringRef("mtransport")) == 0 ||
         Begin->compare_lower(StringRef("protobuf")) == 0 ||
         Begin->compare_lower(StringRef("skia")) == 0 ||
         Begin->compare_lower(StringRef("sfntly")) == 0 ||
         // Gtest uses snprintf as GTEST_SNPRINTF_ with sizeof
         Begin->compare_lower(StringRef("testing")) == 0 ||