Bug 1480787 [wpt PR 12297] - [LayoutNG] Pass constraint space to inline children for min/max., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Fri, 10 Aug 2018 16:05:47 +0000
changeset 431146 52ddadb5708f
parent 431145 0572f9ed6b15
child 431147 541cf966565b
push id34429
push usercbrindusan@mozilla.com
push date2018-08-12 21:49 +0000
treeherdermozilla-central@83d0673bbca4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1480787, 12297, 1162175, 581188
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1480787 [wpt PR 12297] - [LayoutNG] Pass constraint space to inline children for min/max., a=testonly Automatic update from web-platform-tests[LayoutNG] Pass constraint space to inline children for min/max. Orthogonal flow root children are going to need to calculate an extrinsic constraint space. We already got this right for direct block children, but not for floated children of inline child nodes. Three tests start to pass, but I wrote a new test as well, that's more to the point (it used to fail a DCHECK, and then render incorrectly, if we bypassed that). Cq-Include-Trybots: luci.chromium.try‚Äč:linux_layout_tests_layout_ng Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7 Reviewed-on: https://chromium-review.googlesource.com/1162175 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#581188} -- wpt-commits: 25475a3887220baee22dfef032474040401d84e3 wpt-pr: 12297
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-sizing/orthogonal-writing-mode-float-in-inline.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -132770,16 +132770,28 @@
       [
        "/css/css-sizing/intrinsic-percent-non-replaced-005-ref.html",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-sizing/orthogonal-writing-mode-float-in-inline.html": [
+    [
+     "/css/css-sizing/orthogonal-writing-mode-float-in-inline.html",
+     [
+      [
+       "/css/reference/ref-filled-green-100px-square.xht",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-sizing/whitespace-and-break.html": [
     [
      "/css/css-sizing/whitespace-and-break.html",
      [
       [
        "/css/reference/ref-filled-green-100px-square.xht",
        "=="
       ]
@@ -542369,16 +542381,20 @@
   "css/css-sizing/intrinsic-percent-non-replaced-005-ref.html": [
    "38f480c0acdbf4ca9605831e9e48a9998b1bcdd3",
    "support"
   ],
   "css/css-sizing/intrinsic-percent-non-replaced-005.html": [
    "f105d942043c44efa0b9e1ec58798db8f9b64a8c",
    "reftest"
   ],
+  "css/css-sizing/orthogonal-writing-mode-float-in-inline.html": [
+   "fa95069dbf0083b0dc7095d2bb3acf20a6ccf898",
+   "reftest"
+  ],
   "css/css-sizing/whitespace-and-break.html": [
    "f3ea3764478488b949433daccddf710cd0a91006",
    "reftest"
   ],
   "css/css-speech/Integer.html": [
    "40d7bf55b4b2174ad69b0de0240d6e38beef55ef",
    "manual"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-sizing/orthogonal-writing-mode-float-in-inline.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<title>Shrink-to-fit float inside inline inside a shrink-to-fit-container</title>
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<meta name="assert" content="This tests that intrinsic size calculation realizes that the four words are going to fit on the same line in final layout">
+<link rel="help" href="https://www.w3.org/TR/css-sizing-3/#intrinsic-sizes" title="4.1. Intrinsic Sizes">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht" />
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="float:left; height:100px; background:red;">
+  <span>
+    <div style="float:left; writing-mode:vertical-rl; height:100%; line-height:100px; background:green;">
+      &nbsp; &nbsp; &nbsp; &nbsp;
+    </div>
+  </span>
+</div>