Change the stack-class analysis to a warning instead of an error, at least temporarily: the analysis was buggy when originally landed, and there are some heap-allocated autostrings outstanding through the tree.
authorBenjamin Smedberg <benjamin@smedbergs.us>
Mon, 01 Dec 2008 13:59:58 -0500
changeset 22165 52488eb1516811453848c944f4bae861d254daac
parent 22164 211c2be2fa1e02bdb23b5243f75a292f5a322985
child 22166 b824b5caa452cba8b3c5cdff313717af3561b599
push id3835
push userbsmedberg@mozilla.com
push dateTue, 02 Dec 2008 19:08:46 +0000
treeherdermozilla-central@b824b5caa452 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9.1b3pre
Change the stack-class analysis to a warning instead of an error, at least temporarily: the analysis was buggy when originally landed, and there are some heap-allocated autostrings outstanding through the tree.
xpcom/analysis/stack.js
--- a/xpcom/analysis/stack.js
+++ b/xpcom/analysis/stack.js
@@ -179,17 +179,17 @@ function process_cp_pre_genericize(fndec
           if (!destType.isPointer && !destType.isReference) {
             error("operator new not assigned to pointer/ref?", getLocation());
             return;
           }
           destType = destType.type;
 
           let r = isStack(destType);
           if (r)
-            error("constructed object of type '%s' not on the stack: %s".format(destType.name, r), getLocation());
+            warning("constructed object of type '%s' not on the stack: %s".format(destType.name, r), getLocation());
         }
       }
     }
     catch (e if e.TreeCheckError) { }
   }
 
   if (hasAttribute(dehydra_convert(fndecl), 'NS_suppress_stackcheck'))
     return;