Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal
authorRobert Bartlensky <rbartlensky@mozilla.com>
Tue, 17 Jul 2018 12:32:42 +0100
changeset 428017 51abf3731a71
parent 428016 f2a5ae30413b
child 428018 bf5ff5b3b3f2
push id34324
push usernbeleuzu@mozilla.com
push dateTue, 24 Jul 2018 22:19:28 +0000
treeherdermozilla-central@dd386b5b9fa7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmichal
bugs1476016
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476016: Fix DEAD_STORE issue in nsMIMEHeaderParamImpl. r=michal MozReview-Commit-ID: F1p3ji1ezp3
netwerk/mime/nsMIMEHeaderParamImpl.cpp
--- a/netwerk/mime/nsMIMEHeaderParamImpl.cpp
+++ b/netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ -447,17 +447,17 @@ nsMIMEHeaderParamImpl::DoParameterIntern
 
   int32_t paramLen = strlen(aParamName);
 
   while (*str) {
     // find name/value
 
     const char *nameStart = str;
     const char *nameEnd = nullptr;
-    const char *valueStart = str;
+    const char *valueStart = nullptr;
     const char *valueEnd = nullptr;
     bool isQuotedString = false;
 
     NS_ASSERTION(!nsCRT::IsAsciiSpace(*str), "should be after whitespace.");
 
     // Skip forward to the end of this token.
     for (; *str && !nsCRT::IsAsciiSpace(*str) && *str != '=' && *str != ';'; str++)
       ;