Bug 1447982 - Mic source's ApplySettings shouldn't have weird side effects. r=padenot
authorAndreas Pehrson <pehrsons@mozilla.com>
Mon, 26 Mar 2018 11:04:51 +0200
changeset 413028 5180d718e5a550bcf3939cd335a5b47514f9429d
parent 413027 1e59416d1a7715dd5e4a5032d1904a783abcf905
child 413029 e87afd1fda355b3725496591ef30e63f25d5b968
push id33831
push userrgurzau@mozilla.com
push dateThu, 12 Apr 2018 23:07:19 +0000
treeherdermozilla-central@46615d425bcb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1447982
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1447982 - Mic source's ApplySettings shouldn't have weird side effects. r=padenot MozReview-Commit-ID: DCVi5Wy4WN2
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -525,18 +525,16 @@ MediaEngineWebRTCMicrophoneSource::Updat
 
 #undef HANDLE_APM_ERROR
 
 void
 MediaEngineWebRTCMicrophoneSource::ApplySettings(const MediaEnginePrefs& aPrefs)
 {
   AssertIsOnOwningThread();
 
-  mLastPrefs = aPrefs;
-
   RefPtr<MediaEngineWebRTCMicrophoneSource> that = this;
   RefPtr<MediaStreamGraphImpl> graph;
   for (const Allocation& allocation : mAllocations) {
     if (allocation.mStream && allocation.mStream->GraphImpl()) {
       graph = allocation.mStream->GraphImpl();
       break;
     }
   }