Bug 1373999 part 1 - Move layout/generic/nsSelection.cpp verbatim to dom/base/Selection.cpp, and layout/generic/Selection*.h to dom/base/. Also export a few table header files that it needs. r=smaug
authorMats Palmgren <mats@mozilla.com>
Mon, 19 Jun 2017 00:07:36 +0200
changeset 364626 5150df804e436f1b026fcd1867de3f0e515f5acd
parent 364625 e79c16c97d47e3d87b7d317708c716d63a59dcba
child 364627 f76616ab2eb0ab785bdf8e48e5e356528aed0349
push id32050
push usercbook@mozilla.com
push dateMon, 19 Jun 2017 11:37:33 +0000
treeherdermozilla-central@d39cd452b52b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1373999
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1373999 part 1 - Move layout/generic/nsSelection.cpp verbatim to dom/base/Selection.cpp, and layout/generic/Selection*.h to dom/base/. Also export a few table header files that it needs. r=smaug MozReview-Commit-ID: 9YUmEOIHUdc
dom/base/Selection.cpp
dom/base/Selection.h
dom/base/SelectionChangeListener.h
dom/base/moz.build
layout/generic/Selection.h
layout/generic/SelectionChangeListener.h
layout/generic/moz.build
layout/generic/nsSelection.cpp
layout/tables/moz.build
rename from layout/generic/nsSelection.cpp
rename to dom/base/Selection.cpp
rename from layout/generic/Selection.h
rename to dom/base/Selection.h
rename from layout/generic/SelectionChangeListener.h
rename to dom/base/SelectionChangeListener.h
--- a/dom/base/moz.build
+++ b/dom/base/moz.build
@@ -1,14 +1,17 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+with Files('*Selection*'):
+    BUG_COMPONENT = ('Core', 'Selection')
+
 with Files("**"):
     BUG_COMPONENT = ("Core", "DOM")
 
 TEST_DIRS += ['test']
 
 XPIDL_SOURCES += [
     'mozIDOMWindow.idl',
     'nsIContentPolicy.idl',
@@ -189,16 +192,17 @@ EXPORTS.mozilla.dom += [
     'NodeInfoInlines.h',
     'NodeIterator.h',
     'PartialSHistory.h',
     'Pose.h',
     'ProcessGlobal.h',
     'ResponsiveImageSelector.h',
     'SameProcessMessageQueue.h',
     'ScreenOrientation.h',
+    'Selection.h',
     'ShadowRoot.h',
     'StructuredCloneBlob.h',
     'StructuredCloneHolder.h',
     'StructuredCloneTags.h',
     'StyleSheetList.h',
     'SubtleCrypto.h',
     'TabGroup.h',
     'Text.h',
@@ -331,16 +335,17 @@ UNIFIED_SOURCES += [
     'nsXMLNameSpaceMap.cpp',
     'PartialSHistory.cpp',
     'Pose.cpp',
     'PostMessageEvent.cpp',
     'ProcessGlobal.cpp',
     'ResponsiveImageSelector.cpp',
     'SameProcessMessageQueue.cpp',
     'ScreenOrientation.cpp',
+    'Selection.cpp',
     'ShadowRoot.cpp',
     'StructuredCloneBlob.cpp',
     'StructuredCloneHolder.cpp',
     'StyleSheetList.cpp',
     'SubtleCrypto.cpp',
     'TabGroup.cpp',
     'Text.cpp',
     'TextInputProcessor.cpp',
--- a/layout/generic/moz.build
+++ b/layout/generic/moz.build
@@ -62,19 +62,16 @@ with Files('Sticky*'):
     BUG_COMPONENT = ('Core', 'Layout: R & A Pos')
 
 with Files('nsPluginFrame.*'):
     BUG_COMPONENT = ('Core', 'Plug-ins')
 
 with Files('nsVideoFrame.*'):
     BUG_COMPONENT = ('Core', 'Audio/Video')
 
-with Files('*Selection*'):
-    BUG_COMPONENT = ('Core', 'Selection')
-
 EXPORTS += [
     'AsyncScrollBase.h',
     'nsCanvasFrame.h',
     'nsContainerFrame.h',
     'nsDirection.h',
     'nsFrame.h',
     'nsFrameIdList.h',
     'nsFrameList.h',
@@ -114,20 +111,16 @@ EXPORTS.mozilla += [
     'CSSOrderAwareFrameIterator.h',
     'FrameTypeList.h',
     'ReflowInput.h',
     'ReflowOutput.h',
     'ViewportFrame.h',
     'WritingModes.h',
 ]
 
-EXPORTS.mozilla.dom += [
-    'Selection.h',
-]
-
 EXPORTS.mozilla.layout += [
     'FrameChildList.h',
 ]
 
 UNIFIED_SOURCES += [
     'AsyncScrollBase.cpp',
     'BlockReflowInput.cpp',
     'BRFrame.cpp',
@@ -167,17 +160,16 @@ UNIFIED_SOURCES += [
     'nsPageFrame.cpp',
     'nsPlaceholderFrame.cpp',
     'nsRubyBaseContainerFrame.cpp',
     'nsRubyBaseFrame.cpp',
     'nsRubyContentFrame.cpp',
     'nsRubyFrame.cpp',
     'nsRubyTextContainerFrame.cpp',
     'nsRubyTextFrame.cpp',
-    'nsSelection.cpp',
     'nsSimplePageSequenceFrame.cpp',
     'nsSplittableFrame.cpp',
     'nsSubDocumentFrame.cpp',
     'nsTextFrame.cpp',
     'nsTextFrameUtils.cpp',
     'nsTextRunTransformations.cpp',
     'nsVideoFrame.cpp',
     'ReflowInput.cpp',
--- a/layout/tables/moz.build
+++ b/layout/tables/moz.build
@@ -5,17 +5,25 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 with Files('**'):
     BUG_COMPONENT = ('Core', 'Layout: Tables')
 
 MOCHITEST_MANIFESTS += ['test/mochitest.ini']
 
 EXPORTS += [
+    'celldata.h',             # included by nsCellMap.h
+    'nsCellMap.h',            # included by nsTableWrapperFrame.h
     'nsITableCellLayout.h',
+    'nsTableCellFrame.h',     # included by dom/base/Selection.cpp
+    'nsTableFrame.h',         # included by nsTableWrapperFrame.h
+    'nsTableRowFrame.h',      # included by nsTableCellFrame.h
+    'nsTableRowGroupFrame.h', # included by nsTableRowFrame.h
+    'nsTableWrapperFrame.h',  # included by dom/base/Selection.cpp
+    'TableArea.h',            # included by nsCellMap.h
 ]
 
 UNIFIED_SOURCES += [
     'BasicTableLayoutStrategy.cpp',
     'FixedTableLayoutStrategy.cpp',
     'nsCellMap.cpp',
     'nsTableCellFrame.cpp',
     'nsTableColFrame.cpp',