Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. r=baku
authorBrad Werth <bwerth@mozilla.com>
Thu, 20 Jul 2017 15:45:30 -0700
changeset 370182 4e853e81c2be70c041fbae19e4e30dc7e97e86c2
parent 370181 095cbbcf0240ae8465377992175744079df45da5
child 370183 a8bb5530a0925ac0823bdb6d525cbc6f304f8928
child 370234 45b4405c24ca291e24053c708c4620a9bda73438
push id32212
push userkwierso@gmail.com
push dateSat, 22 Jul 2017 00:51:16 +0000
treeherdermozilla-central@a8bb5530a092 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1382863
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382863 Part 1: Move MessagePortChild constructor out of inline, creating a vtable needed for clang compilation. r=baku MozReview-Commit-ID: 6xO9s3qlqJq
dom/messagechannel/MessagePortChild.cpp
dom/messagechannel/MessagePortChild.h
--- a/dom/messagechannel/MessagePortChild.cpp
+++ b/dom/messagechannel/MessagePortChild.cpp
@@ -6,16 +6,21 @@
 #include "MessagePortChild.h"
 #include "MessagePort.h"
 #include "mozilla/dom/MessageEvent.h"
 #include "mozilla/ipc/PBackgroundChild.h"
 
 namespace mozilla {
 namespace dom {
 
+MessagePortChild::MessagePortChild()
+  : mPort(nullptr)
+{
+}
+
 mozilla::ipc::IPCResult
 MessagePortChild::RecvStopSendingDataConfirmed()
 {
   MOZ_ASSERT(mPort);
   mPort->StopSendingDataConfirmed();
   MOZ_ASSERT(!mPort);
   return IPC_OK();
 }
--- a/dom/messagechannel/MessagePortChild.h
+++ b/dom/messagechannel/MessagePortChild.h
@@ -14,17 +14,17 @@ namespace dom {
 
 class MessagePort;
 
 class MessagePortChild final : public PMessagePortChild
 {
 public:
   NS_INLINE_DECL_REFCOUNTING(MessagePortChild)
 
-  MessagePortChild() : mPort(nullptr) {}
+  MessagePortChild();
 
   void SetPort(MessagePort* aPort)
   {
     mPort = aPort;
   }
 
 private:
   ~MessagePortChild()