Bug 635737 - Zoom animation frame is rotated when we zoom out of a non-top stacked tab [f=ttaubert, r=ian, a=beltzner]
authorMichael Yoshitaka Erlewine <mitcho@mitcho.com>
Tue, 22 Feb 2011 15:48:41 -0500
changeset 63006 4e6809c053cdf1175bff043291f30d8e16c843be
parent 63005 27ab44a83e3e6a57564516f3d70c59815bcf562a
child 63007 0f879ec8b3d29eff358fab2b3d5d390d9eb7f6da
push id18987
push usershaver@mozilla.com
push dateWed, 23 Feb 2011 18:50:13 +0000
treeherdermozilla-central@41297d3b8511 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersian, beltzner
bugs635737
milestone2.0b13pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 635737 - Zoom animation frame is rotated when we zoom out of a non-top stacked tab [f=ttaubert, r=ian, a=beltzner]
browser/base/content/tabview/tabitems.js
--- a/browser/base/content/tabview/tabitems.js
+++ b/browser/base/content/tabview/tabitems.js
@@ -697,16 +697,21 @@ TabItem.prototype = Utils.extend(new Ite
         complete();
     };
 
     this.shouldHideCachedData = true;
     TabItems._update(this.tab);
 
     $tab.addClass("front");
 
+    // If we're in a stacked group, make sure we become the
+    // topChild now so that we show the zoom animation correctly.
+    if (this.parent && this.parent.isStacked())
+      this.parent.setTopChild(this);
+
     let animateZoom = gPrefBranch.getBoolPref("animate_zoom");
     if (animateZoom) {
       // The scaleCheat of 2 here is a clever way to speed up the zoom-out
       // code. See getZoomTransform() below.
       let transform = this.getZoomTransform(2);
       TabItems.pausePainting();
 
       $canvas.css({