Bug 899463 - [fig] Bookmark Edit via context menu causes crash, r=margaret
authorMark Capella <markcapella@twcny.rr.com>
Tue, 30 Jul 2013 17:55:14 -0400
changeset 143486 4e2ac48c10392f34f5f37a8b3fc1bc01efadad8a
parent 143485 623462249b2517e8fb2f4bf5a13e7378335435f6
child 143487 e169d1c5043cbb2799a7fb4adb58f06fae871db5
push id25130
push userlrocha@mozilla.com
push dateWed, 21 Aug 2013 09:41:27 +0000
treeherdermozilla-central@b2486721572e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmargaret
bugs899463
milestone25.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 899463 - [fig] Bookmark Edit via context menu causes crash, r=margaret
mobile/android/base/home/HomeFragment.java
--- a/mobile/android/base/home/HomeFragment.java
+++ b/mobile/android/base/home/HomeFragment.java
@@ -143,17 +143,18 @@ abstract class HomeFragment extends Frag
 
                 final String url = (info.inReadingList ? ReaderModeUtils.getAboutReaderForUrl(info.url, true) : info.url);
                 Tabs.getInstance().loadUrl(url, flags);
                 Toast.makeText(context, R.string.new_tab_opened, Toast.LENGTH_SHORT).show();
                 return true;
             }
 
             case R.id.home_edit_bookmark: {
-                new EditBookmarkDialog(context).show(info.url);
+                // UI Dialog associates to the activity context, not the applications'.
+                new EditBookmarkDialog(getActivity()).show(info.url);
                 return true;
             }
 
             case R.id.home_open_in_reader: {
                 final String url = ReaderModeUtils.getAboutReaderForUrl(info.url, true);
                 Tabs.getInstance().loadUrl(url, Tabs.LOADURL_NONE);
                 return true;
             }