bug 1486137 - fix the stream ID check when counting TRR streams r=nwgh
☠☠ backed out by 0fc842ad0629 ☠ ☠
authorDaniel Stenberg <daniel@haxx.se>
Thu, 13 Sep 2018 14:48:46 +0000
changeset 436152 4dfb623bb11e7fa244e66ec5fde83414c29f4736
parent 436151 f2aad0f0e44d9320dd0c38dbddd7f2ae64f4810c
child 436153 e9b9cb4d4328de4eb95f7b64bf08f0c0e5aeb1f2
push id34630
push usernerli@mozilla.com
push dateThu, 13 Sep 2018 21:58:06 +0000
treeherdermozilla-central@71736f1f0f3e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnwgh
bugs1486137
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1486137 - fix the stream ID check when counting TRR streams r=nwgh MozReview-Commit-ID: DzOu1dRlWtg Differential Revision: https://phabricator.services.mozilla.com/D5748
netwerk/protocol/http/Http2Session.cpp
--- a/netwerk/protocol/http/Http2Session.cpp
+++ b/netwerk/protocol/http/Http2Session.cpp
@@ -400,17 +400,17 @@ Http2Session::RegisterStreamID(Http2Stre
         IdleTime() >= gHttpHandler->CheckIfConnectionIsStalledOnlyIfIdleForThisAmountOfSeconds()) {
       // If a connection was using the TCP FastOpen and it was idle for a
       // long time we should check for stalls like bug 1395494.
       mCheckNetworkStallsWithTFO = true;
       mLastRequestBytesSentTime = PR_IntervalNow();
     }
   }
 
-  if (stream->StreamID() & 1) {
+  if (aNewID & 1) {
     // don't count push streams here
     MOZ_ASSERT(stream->Transaction(), "no transation for the stream!");
     RefPtr<nsHttpConnectionInfo> ci(stream->Transaction()->ConnectionInfo());
     if (ci && ci->GetTrrUsed()) {
       IncrementTrrCounter();
     }
   }
   return aNewID;