Bug 1121623 part 4. Remove AudioScheduledSourceNode::WrapObject. r=padenot
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 23 May 2019 11:40:14 +0000
changeset 475386 4d9f7977a103255ef5d9e9424b6233482b25c304
parent 475385 8e672b4e0a3e3ed151a91abbca41cebf2692dd4f
child 475387 1e7a53dbff7b0a55633a7b57c4229259f47cd492
push id36060
push usercbrindusan@mozilla.com
push dateFri, 24 May 2019 21:47:21 +0000
treeherdermozilla-central@ac95bdf3c0b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1121623
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1121623 part 4. Remove AudioScheduledSourceNode::WrapObject. r=padenot It's dead code, because AudioScheduledSourceNode is an abstract class and all subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32202
dom/media/webaudio/AudioScheduledSourceNode.cpp
dom/media/webaudio/AudioScheduledSourceNode.h
--- a/dom/media/webaudio/AudioScheduledSourceNode.cpp
+++ b/dom/media/webaudio/AudioScheduledSourceNode.cpp
@@ -1,26 +1,19 @@
 /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim:set ts=2 sw=2 sts=2 et cindent: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "AudioScheduledSourceNode.h"
-#include "mozilla/dom/AudioScheduledSourceNodeBinding.h"
 
 namespace mozilla {
 namespace dom {
 
 AudioScheduledSourceNode::AudioScheduledSourceNode(
     AudioContext* aContext, uint32_t aChannelCount,
     ChannelCountMode aChannelCountMode,
     ChannelInterpretation aChannelInterpretation)
     : AudioNode(aContext, aChannelCount, aChannelCountMode,
                 aChannelInterpretation) {}
-
-JSObject* AudioScheduledSourceNode::WrapObject(
-    JSContext* aCx, JS::Handle<JSObject*> aGivenProto) {
-  return AudioScheduledSourceNode_Binding::Wrap(aCx, this, aGivenProto);
-}
-
 }  // namespace dom
 }  // namespace mozilla
--- a/dom/media/webaudio/AudioScheduledSourceNode.h
+++ b/dom/media/webaudio/AudioScheduledSourceNode.h
@@ -12,19 +12,16 @@
 
 namespace mozilla {
 namespace dom {
 
 class AudioContext;
 
 class AudioScheduledSourceNode : public AudioNode {
  public:
-  JSObject* WrapObject(JSContext* aCx,
-                       JS::Handle<JSObject*> aGivenProto) override;
-
   virtual void Start(double aWhen, ErrorResult& aRv) = 0;
   virtual void Stop(double aWhen, ErrorResult& aRv) = 0;
 
   IMPL_EVENT_HANDLER(ended)
 
  protected:
   AudioScheduledSourceNode(AudioContext* aContext, uint32_t aChannelCount,
                            ChannelCountMode aChannelCountMode,