Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen
authorTom Ritter <tom@mozilla.com>
Fri, 11 May 2018 08:16:13 -0500
changeset 418488 4d7c95672b79599a1192419115e2b25245f7fad1
parent 418487 843b90da1fad40d2379d327a26288663acd05539
child 418489 cb2a199d50d1f79aafd93861ed7f6bc3f1f24eef
push id34003
push usershindli@mozilla.com
push dateWed, 16 May 2018 18:31:07 +0000
treeherdermozilla-central@a35fc68a2471 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen
bugs1460882
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1460882 Disable SANDBOX_EXPORTS for the MinGW Build r=bobowen MozReview-Commit-ID: 2muTxIYUx6F
security/sandbox/moz.build
old mode 100644
new mode 100755
--- a/security/sandbox/moz.build
+++ b/security/sandbox/moz.build
@@ -151,19 +151,21 @@ elif CONFIG['OS_ARCH'] == 'WINNT':
             'chromium/sandbox/win/src/service_resolver_64.cc',
         ]
     else:
         SOURCES += [
             'chromium/sandbox/win/src/resolver_32.cc',
             'chromium/sandbox/win/src/service_resolver_32.cc',
         ]
 
-    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM', 'SANDBOX_EXPORTS',
+    for var in ('UNICODE', '_UNICODE', 'NS_NO_XPCOM',
                 '_CRT_RAND_S', 'CHROMIUM_SANDBOX_BUILD'):
         DEFINES[var] = True
+    if CONFIG['CC_TYPE'] != 'gcc':
+        DEFINES['SANDBOX_EXPORTS'] = True
 
     LOCAL_INCLUDES += ['/security/sandbox/chromium-shim']
     LOCAL_INCLUDES += ['/security/sandbox/chromium']
     LOCAL_INCLUDES += ['/nsprpub']
 
     DisableStlWrapping()
 
     # Suppress warnings in third-party code.