Bug 1396335 - Clean up unnecessary style rules in toolbox.css. r=pbro
authorGabriel Luong <gabriel.luong@gmail.com>
Mon, 04 Sep 2017 08:37:09 -0400
changeset 378860 4ce738a785677c1f8a4421903f713c218af3d460
parent 378859 a3037a3d59ebed30d297c662d35ab376d48e22a4
child 378861 b9ea5a59464ceaf66879e021759e4a89686b0bee
push id32443
push userarchaeopteryx@coole-files.de
push dateTue, 05 Sep 2017 09:41:20 +0000
treeherdermozilla-central@3ecda4678c49 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1396335
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1396335 - Clean up unnecessary style rules in toolbox.css. r=pbro
devtools/client/themes/toolbox.css
--- a/devtools/client/themes/toolbox.css
+++ b/devtools/client/themes/toolbox.css
@@ -38,24 +38,21 @@
   --command-rulers-image: url(images/firebug/command-rulers.svg);
   --command-measure-image: url(images/firebug/command-measure.svg);
 }
 
 /* Toolbox tabbar */
 
 .devtools-tabbar {
   -moz-appearance: none;
+  display: flex;
+  background: var(--theme-tab-toolbar-background);
+  border-bottom: 1px solid var(--theme-splitter-color);
+  box-sizing: border-box;
   min-height: 29px;
-  border: 0px solid;
-  border-bottom-width: 1px;
-  padding: 0;
-  background: var(--theme-tab-toolbar-background);
-  border-bottom-color: var(--theme-splitter-color);
-  display: flex;
-  box-sizing: border-box;
 }
 
 .toolbox-tabs-wrapper {
   position: relative;
   display: flex;
   flex: 1;
 }
 
@@ -140,22 +137,20 @@
 
 /* Save space on the tab-strip in Firebug theme */
 .theme-firebug .devtools-tab {
   -moz-box-flex: initial;
 }
 
 .theme-dark .devtools-tab {
   color: var(--theme-body-color-alt);
-  border-color: #42484f;
 }
 
 .theme-light .devtools-tab {
   color: var(--theme-body-color);
-  border-color: var(--theme-splitter-color);
 }
 
 .theme-dark .devtools-tab:hover {
   color: #ced3d9;
 }
 
 .devtools-tab:hover {
   background-color: var(--theme-toolbar-hover);
@@ -210,31 +205,16 @@
 }
 
 .devtools-tab:hover > img,
 .devtools-tab:active > img,
 .devtools-tab.selected > img {
   opacity: 1;
 }
 
-.toolbox-tabs .devtools-tab.selected,
-.toolbox-tabs .devtools-tab.highlighted,
-.toolbox-tabs .devtools-tab.selected + .devtools-tab,
-.toolbox-tabs .devtools-tab.highlighted + .devtools-tab {
-  border-inline-start-color: transparent;
-}
-
-.toolbox-tabs .devtools-tab:first-child {
-  border-inline-start-width: 0;
-}
-
-.toolbox-tabs .devtools-tab:last-child {
-  border-inline-end-width: 1px;
-}
-
 .devtools-tab:not(.highlighted) > .highlighted-icon,
 .devtools-tab.selected > .highlighted-icon,
 .devtools-tab:not(.selected).highlighted > .default-icon {
   display: none;
 }
 
 /* The options tab is special - it doesn't have the same parent
    as the other tabs (toolbox-option-container vs toolbox-tabs) */
@@ -275,25 +255,16 @@
 #toolbox-dock-bottom-minimize::before {
   background-image: url("chrome://devtools/skin/images/dock-bottom-minimize@2x.png");
 }
 
 #toolbox-dock-bottom-minimize.minimized::before {
   background-image: url("chrome://devtools/skin/images/dock-bottom-maximize@2x.png");
 }
 
-/**
- * Ensure that when the toolbar collapses in on itself when there is not enough room
- * that it still looks reasonable.
- */
-.devtools-tabbar > div {
-  background-color: var(--theme-tab-toolbar-background);
-  z-index: 0;
-}
-
 /* Command buttons */
 
 .command-button,
 #toolbox-controls > button,
 #toolbox-dock-buttons > button {
   /* !important is needed to override .devtools-button rules in common.css */
   padding: 0 !important;
   margin: 0 !important;