Bug 1273669. Make JS::CustomAutoRooter::Inner final. r=billm
authorJeff Muizelaar <jmuizelaar@mozilla.com>
Tue, 24 May 2016 15:38:18 -0400
changeset 298825 4ce461d9ec8e87dcfcfc9f5d2ab1f405b2e4318f
parent 298824 0e1aa8af35b8e3fc54a2e041e131852c76f73d0c
child 298826 c4f8d92b1c7b3ba67385388d626d0d7cb10f88ae
push id30285
push usercbook@mozilla.com
push dateWed, 25 May 2016 13:06:07 +0000
treeherdermozilla-central@d6d4e8417d2f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbillm
bugs1273669
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1273669. Make JS::CustomAutoRooter::Inner final. r=billm Fixes clang virtual destructor warnings.
js/src/vm/Shape.h
--- a/js/src/vm/Shape.h
+++ b/js/src/vm/Shape.h
@@ -1005,17 +1005,17 @@ inline
 StackBaseShape::StackBaseShape(Shape* shape)
   : flags(shape->getObjectFlags()),
     clasp(shape->getObjectClass()),
     compartment(shape->compartment())
 {}
 
 class MOZ_RAII AutoRooterGetterSetter
 {
-    class Inner : private JS::CustomAutoRooter
+    class Inner final : private JS::CustomAutoRooter
     {
       public:
         inline Inner(ExclusiveContext* cx, uint8_t attrs, GetterOp* pgetter_, SetterOp* psetter_);
 
       private:
         virtual void trace(JSTracer* trc);
 
         uint8_t attrs;