Bug 1377591 - Make nsCocoaWindow and nsChildView 'final' to devirtualize some calls. r=mstange
authorMats Palmgren <mats@mozilla.com>
Wed, 05 Jul 2017 02:01:45 +0200
changeset 367345 4ccb89990d136aaea04c3adfcb5a4e436467eecb
parent 367344 a4a27ab70450302d6c599be8160d0f4860b4c29e
child 367346 9ee475ea4dfb2e7b710ea95e3d2309c859fc5789
push id32130
push usercbook@mozilla.com
push dateWed, 05 Jul 2017 11:01:49 +0000
treeherdermozilla-central@211d4dd61025 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmstange
bugs1377591
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1377591 - Make nsCocoaWindow and nsChildView 'final' to devirtualize some calls. r=mstange MozReview-Commit-ID: 4sXYV9sVEZl
widget/cocoa/nsChildView.h
widget/cocoa/nsCocoaWindow.h
--- a/widget/cocoa/nsChildView.h
+++ b/widget/cocoa/nsChildView.h
@@ -292,17 +292,17 @@ public:
 };
 
 //-------------------------------------------------------------------------
 //
 // nsChildView
 //
 //-------------------------------------------------------------------------
 
-class nsChildView : public nsBaseWidget
+class nsChildView final : public nsBaseWidget
 {
 private:
   typedef nsBaseWidget Inherited;
   typedef mozilla::layers::IAPZCTreeManager IAPZCTreeManager;
 
 public:
   nsChildView();
 
--- a/widget/cocoa/nsCocoaWindow.h
+++ b/widget/cocoa/nsCocoaWindow.h
@@ -201,17 +201,17 @@ typedef struct _nsCocoaWindowList {
 - (void)placeWindowButtons:(NSRect)aRect;
 - (void)placeFullScreenButton:(NSRect)aRect;
 - (NSPoint)windowButtonsPositionWithDefaultPosition:(NSPoint)aDefaultPosition;
 - (NSPoint)fullScreenButtonPositionWithDefaultPosition:(NSPoint)aDefaultPosition;
 - (void)setTemporaryBackgroundColor;
 - (void)restoreBackgroundColor;
 @end
 
-class nsCocoaWindow : public nsBaseWidget, public nsPIWidgetCocoa
+class nsCocoaWindow final : public nsBaseWidget, public nsPIWidgetCocoa
 {
 private:
   typedef nsBaseWidget Inherited;
 
 public:
 
     nsCocoaWindow();