Bug 1472942 - Part 1. Remove unused paramter of HTMLTooltip.show from SwatchBaseEditorTooltip. r=jdescottes
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Thu, 27 Sep 2018 07:15:18 +0000
changeset 438514 4ba6db4fd39bb4e5bf8a1a5422dd8e58ef6a646f
parent 438513 42fac3928107b21fb99e63649386484acb34df5f
child 438515 2430fbe8fef663150a247783196dd7d91dc4d867
push id34724
push userccoroiu@mozilla.com
push dateThu, 27 Sep 2018 21:36:09 +0000
treeherdermozilla-central@e1d012b989ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1472942, 1307481
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472942 - Part 1. Remove unused paramter of HTMLTooltip.show from SwatchBaseEditorTooltip. r=jdescottes SwatchBaseEditorTooltip specify the "topcentor bototmleft" to second parameter of HTMLTooltip.show(). However, this parameter will ignore since show() function require the second parameter as the object, not the string. Bug 1307481 comment 42 has pointed out this parameter. Differential Revision: https://phabricator.services.mozilla.com/D7043
devtools/client/shared/widgets/tooltip/SwatchBasedEditorTooltip.js
--- a/devtools/client/shared/widgets/tooltip/SwatchBasedEditorTooltip.js
+++ b/devtools/client/shared/widgets/tooltip/SwatchBasedEditorTooltip.js
@@ -105,17 +105,17 @@ class SwatchBasedEditorTooltip {
   show() {
     const tooltipAnchor = this.useInline ?
       this.activeSwatch.closest(`.${INLINE_TOOLTIP_CLASS}`) :
       this.activeSwatch;
 
     if (tooltipAnchor) {
       const onShown = this.tooltip.once("shown");
 
-      this.tooltip.show(tooltipAnchor, "topcenter bottomleft");
+      this.tooltip.show(tooltipAnchor);
       this.tooltip.once("hidden", () => this.onTooltipHidden());
 
       return onShown;
     }
 
     return Promise.resolve();
   }