Bug 1090016 - Part 2: Replace SpiderMonkey's --enable-sm-fail-on-warnings flag with explicit moz.build FAIL_ON_WARNINGS. r=ted
authorChris Peterson <cpeterson@mozilla.com>
Mon, 03 Nov 2014 18:46:10 -0800
changeset 214306 4b5bdae6ae045b273fba83b030f8209caea6fcab
parent 214305 4e565c7ef9f303886d80117cc6f0b735c844557a
child 214307 9ee314a76de3124dc99594bda5b3aad61e07f52a
push id27777
push usercbook@mozilla.com
push dateThu, 06 Nov 2014 12:50:56 +0000
treeherdermozilla-central@0c66a9fd9085 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1090016
milestone36.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1090016 - Part 2: Replace SpiderMonkey's --enable-sm-fail-on-warnings flag with explicit moz.build FAIL_ON_WARNINGS. r=ted
js/src/configure.in
js/src/editline/moz.build
js/src/gdb/moz.build
js/xpconnect/shell/moz.build
--- a/js/src/configure.in
+++ b/js/src/configure.in
@@ -3031,27 +3031,16 @@ elif test "$GNU_CC"; then
 
     if test -n "$MOZ_PGO"; then
         MOZ_C_SUPPORTS_WARNING(-W, no-error=coverage-mismatch, ac_c_has_noerror_coverage_mismatch)
         MOZ_CXX_SUPPORTS_WARNING(-W, no-error=coverage-mismatch, ac_cxx_has_noerror_coverage_mismatch)
     fi
 fi
 
 dnl ========================================================
-dnl = Enable treating compile warnings as errors
-dnl ========================================================
-MOZ_ARG_ENABLE_BOOL(sm-fail-on-warnings,
-[  --enable-sm-fail-on-warnings
-                          Enable warnings as errors],
-    FAIL_ON_WARNINGS=1,
-    FAIL_ON_WARNINGS= )
-
-AC_SUBST(FAIL_ON_WARNINGS)
-
-dnl ========================================================
 dnl = Enable trace malloc
 dnl ========================================================
 NS_TRACE_MALLOC=${MOZ_TRACE_MALLOC}
 MOZ_ARG_ENABLE_BOOL(trace-malloc,
 [  --enable-trace-malloc   Enable malloc tracing],
     NS_TRACE_MALLOC=1,
     NS_TRACE_MALLOC= )
 if test "$NS_TRACE_MALLOC"; then
--- a/js/src/editline/moz.build
+++ b/js/src/editline/moz.build
@@ -11,8 +11,10 @@ UNIFIED_SOURCES += [
     'sysunix.c',
 ]
 
 FORCE_STATIC_LIB = True
 
 for var in ('ANSI_ARROWS', 'HAVE_TCGETATTR', 'HIDE', 'USE_DIRENT', 'SYS_UNIX',
             'HAVE_STDLIB', 'UNIQUE_HISTORY'):
     DEFINES[var] = True
+
+FAIL_ON_WARNINGS = True
--- a/js/src/gdb/moz.build
+++ b/js/src/gdb/moz.build
@@ -26,8 +26,10 @@ for var in ('EXPORT_JS_API', 'IMPL_MFBT'
 LOCAL_INCLUDES += ['..']
 GENERATED_INCLUDES += ['..']
 
 USE_LIBS += [
     'static:js',
 ]
 
 OS_LIBS += CONFIG['MOZ_ZLIB_LIBS']
+
+FAIL_ON_WARNINGS = True
--- a/js/xpconnect/shell/moz.build
+++ b/js/xpconnect/shell/moz.build
@@ -30,8 +30,10 @@ LOCAL_INCLUDES += [
 
 if CONFIG['_MSC_VER']:
     # Always enter a Windows program through wmain, whether or not we're
     # a console application.
     WIN32_EXE_LDFLAGS += ['-ENTRY:wmainCRTStartup']
 
 if CONFIG['OS_ARCH'] == 'WINNT':
     RCINCLUDE = 'xpcshell.rc'
+
+FAIL_ON_WARNINGS = True