Bug 1447045 - Increase maximize delta to 22 px. r=maja_zf
authorAndreas Tolfsen <ato@sny.no>
Mon, 19 Mar 2018 16:35:26 +0000
changeset 409000 4ac3210cae5118c326f95566e68a2e470d749fcf
parent 408999 c7d3eda7dedcfd0d3ec6840d55d403eabec89633
child 409001 88130a542fb3041239eb0a257f1e6db411e35f5c
push id33671
push usercsabou@mozilla.com
push dateTue, 20 Mar 2018 22:23:32 +0000
treeherdermozilla-central@e2e874ceae78 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmaja_zf
bugs1447045
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1447045 - Increase maximize delta to 22 px. r=maja_zf Linux window managers and desktop environments can cause the available surface area of the screen to be shrunk due to UI elements such as menus. Window managers can also add additional window decorations that are outside the control of Firefox. When X11 forwarding a Firefox window to macOS the XQuartz window decoration adds 22 px. This patch increases the delta from 8 px. MozReview-Commit-ID: 8I6G6cZvAmD
testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py
@@ -29,17 +29,17 @@ class TestWindowMaximize(MarionetteTestC
     def tearDown(self):
         self.marionette.set_window_size(
             self.original_size["width"], self.original_size["height"])
 
     def assert_window_maximized(self, actual, delta=None):
         if self.marionette.session_capabilities["platformName"] == "windows_nt":
             delta = 16
         else:
-            delta = 8
+            delta = 22
 
         self.assertGreaterEqual(
             actual["width"], self.max["width"] - delta,
             msg="Window width is not within {delta} px of availWidth: "
                 "current width {current} should be greater than or equal to max width {max}"
                 .format(delta=delta, current=actual["width"], max=self.max["width"] - delta))
         self.assertGreaterEqual(
             actual["height"], self.max["height"] - delta,