Bug 1216081 - OscillatorNodeEngine::mFinalFrequency is used uninitialised. r=padenot.
authorJulian Seward <jseward@acm.org>
Tue, 20 Oct 2015 12:59:37 +0200
changeset 268524 4aa9e709ddf7d43575995dcccbb12f33a1c2792d
parent 268523 80f151ddd504ea383874c03415e44805e488d983
child 268525 481e1b42d8867180885cc60ade12c31917ebdc0b
push id29552
push userkwierso@gmail.com
push dateTue, 20 Oct 2015 20:22:39 +0000
treeherdermozilla-central@0416fbbd3a63 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1216081
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1216081 - OscillatorNodeEngine::mFinalFrequency is used uninitialised. r=padenot.
dom/media/webaudio/OscillatorNode.cpp
--- a/dom/media/webaudio/OscillatorNode.cpp
+++ b/dom/media/webaudio/OscillatorNode.cpp
@@ -32,16 +32,18 @@ public:
     , mDestination(aDestination->Stream())
     , mStart(-1)
     , mStop(STREAM_TIME_MAX)
     // Keep the default values in sync with OscillatorNode::OscillatorNode.
     , mFrequency(440.f)
     , mDetune(0.f)
     , mType(OscillatorType::Sine)
     , mPhase(0.)
+    , mFinalFrequency(0.)
+    , mPhaseIncrement(0.)
     , mRecomputeParameters(true)
     , mCustomLength(0)
   {
     MOZ_ASSERT(NS_IsMainThread());
     mBasicWaveFormCache = aDestination->Context()->GetBasicWaveFormCache();
   }
 
   void SetSourceStream(AudioNodeStream* aSource)