Bug 1482928 [wpt PR 12432] - Avoid using Promise.prototype.finally in idlharness.js, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Wed, 15 Aug 2018 09:57:42 +0000
changeset 431743 4a89638926789e52db93b8054e6020f6ef565c25
parent 431742 e66ad8dd3570eb2e9dafc370c67c5c6a59dcec26
child 431744 9ee4484da82cd63bb88e713a2d97570b6f33eaac
push id34451
push userebalazs@mozilla.com
push dateThu, 16 Aug 2018 09:25:15 +0000
treeherdermozilla-central@161817e6d127 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1482928, 12432, 12428
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1482928 [wpt PR 12432] - Avoid using Promise.prototype.finally in idlharness.js, a=testonly Automatic update from web-platform-testsAvoid using Promise.prototype.finally in idlharness.js In this context, using .then() achieves the same thing because of the preceding .catch(). Fixes https://github.com/web-platform-tests/wpt/issues/12428. -- wpt-commits: 8b3baca3d46530aa04a12afa2fe00951800e0f2c wpt-pr: 12432
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/resources/idlharness.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -626108,17 +626108,17 @@
    "d760e7c76d3050973e365021766cb00488b16156",
    "support"
   ],
   "resources/chromium/webxr-test.js.headers": [
    "6805c323df5a975231648b830e33ce183c3cbbd3",
    "support"
   ],
   "resources/idlharness.js": [
-   "4b1ee6c30a808568c3d031bbd9ac28b7745f1f23",
+   "379785cd68517fe40d4b28d2dc6e2f8e63ea4af7",
    "support"
   ],
   "resources/idlharness.js.headers": [
    "5e8f640c6659d176eaca4c71cc1798b7285540b7",
    "support"
   ],
   "resources/readme.md": [
    "97d2e6f92203d126ba585216c5605b581454af1e",
--- a/testing/web-platform/tests/resources/idlharness.js
+++ b/testing/web-platform/tests/resources/idlharness.js
@@ -3215,17 +3215,17 @@ function idl_test(srcs, deps, idl_setup_
                 }
             })
             .then(function() {
                 if (idl_setup_func) {
                     return idl_setup_func(idl_array, t);
                 }
             })
             .catch(function(e) { setup_error = e || 'IDL setup failed.'; })
-            .finally(function () {
+            .then(function () {
                 var error = setup_error;
                 try {
                     idl_array.test(); // Test what we can.
                 } catch (e) {
                     // If testing fails hard here, the original setup error
                     // is more likely to be the real cause.
                     error = error || e;
                 }