author | Sebastian Hengst <archaeopteryx@coole-files.de> |
Mon, 28 Aug 2017 09:59:11 +0200 | |
changeset 377195 | 4918edc849c89833d59b07d2e914c0432c9ed99f |
parent 377194 | 969091228f162590b3ec1446d209700d707061c7 |
child 377196 | 0aaab26e4aa9dddcb74a97112516831e8dcd1252 |
push id | 32402 |
push user | archaeopteryx@coole-files.de |
push date | Mon, 28 Aug 2017 14:47:04 +0000 |
treeherder | mozilla-central@d5b6d113cf17 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
bugs | 842782 |
milestone | 57.0a1 |
backs out | ba812092214c146456ac1c8fedf2faf3eefc5ce5 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/dom/html/HTMLVideoElement.cpp +++ b/dom/html/HTMLVideoElement.cpp @@ -43,17 +43,16 @@ namespace dom { static bool sVideoStatsEnabled; NS_IMPL_ELEMENT_CLONE(HTMLVideoElement) HTMLVideoElement::HTMLVideoElement(already_AddRefed<NodeInfo>& aNodeInfo) : HTMLMediaElement(aNodeInfo) , mUseScreenWakeLock(true) - , mIsOrientationLocked(false) { } HTMLVideoElement::~HTMLVideoElement() { } nsresult HTMLVideoElement::GetVideoSize(nsIntSize* size)
--- a/dom/html/HTMLVideoElement.h +++ b/dom/html/HTMLVideoElement.h @@ -4,17 +4,16 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #ifndef mozilla_dom_HTMLVideoElement_h #define mozilla_dom_HTMLVideoElement_h #include "mozilla/Attributes.h" #include "mozilla/dom/HTMLMediaElement.h" -#include "MediaPrefs.h" namespace mozilla { class FrameStatistics; namespace dom { class WakeLock; @@ -135,46 +134,28 @@ public: void NotifyOwnerDocumentActivityChanged() override; // Gives access to the decoder's frame statistics, if present. FrameStatistics* GetFrameStatistics(); already_AddRefed<VideoPlaybackQuality> GetVideoPlaybackQuality(); - - bool MozOrientationLockEnabled() const - { - return MediaPrefs::VideoOrientationLockEnabled(); - } - - bool MozIsOrientationLocked() const - { - return mIsOrientationLocked; - } - - void SetMozIsOrientationLocked(bool aLock) - { - mIsOrientationLocked = aLock; - } - protected: virtual ~HTMLVideoElement(); virtual JSObject* WrapNode(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) override; virtual void WakeLockCreate() override; virtual void WakeLockRelease() override; void UpdateScreenWakeLock(); bool mUseScreenWakeLock; RefPtr<WakeLock> mScreenWakeLock; - bool mIsOrientationLocked; - private: static void MapAttributesIntoRule(const nsMappedAttributes* aAttributes, GenericSpecifiedValues* aGenericData); static bool IsVideoStatsEnabled(); double TotalPlayTime() const; };
--- a/dom/webidl/HTMLVideoElement.webidl +++ b/dom/webidl/HTMLVideoElement.webidl @@ -44,23 +44,15 @@ partial interface HTMLVideoElement { readonly attribute double mozFrameDelay; // True if the video has an audio track available. readonly attribute boolean mozHasAudio; // True if the video should use a screen wake lock. [Pref="dom.wakelock.enabled", Func="Navigator::HasWakeLockSupport"] attribute boolean mozUseScreenWakeLock; - - // Attributes for builtin video controls to lock screen orientation. - // True if video controls should lock orientation when fullscreen. - [Pref="media.videocontrols.lock-video-orientation", Func="IsChromeOrXBL"] - readonly attribute boolean mozOrientationLockEnabled; - // True if screen orientation is locked by video controls. - [Pref="media.videocontrols.lock-video-orientation", Func="IsChromeOrXBL"] - attribute boolean mozIsOrientationLocked; }; // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#idl-def-HTMLVideoElement partial interface HTMLVideoElement { [Func="mozilla::dom::MediaSource::Enabled", NewObject] VideoPlaybackQuality getVideoPlaybackQuality(); };