Bug 1517025 - Change default pref URLs to localhost instead of %(server) r=Gijs
☠☠ backed out by 22471aa9be27 ☠ ☠
authorValentin Gosu <valentin.gosu@gmail.com>
Mon, 21 Jan 2019 09:55:02 +0000
changeset 454657 48c7d643d2fa9caf7ebe07831cb5d15fa7f82a76
parent 454656 419cb778d5316033fc772898d2160e9998c6ee14
child 454658 c29889dea969f8ccbce2f5a2a479f6468510e6a6
push id35409
push userrmaries@mozilla.com
push dateMon, 21 Jan 2019 17:48:45 +0000
treeherdermozilla-central@4977d02e1191 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1517025
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1517025 - Change default pref URLs to localhost instead of %(server) r=Gijs We now disallow the % sign in the hostname of a URL. If the app.normandy.api_url pref isn't set explicitly, it'll remain the default set in xpcshell/user.js: https://%(server)s/selfsupport-dummy/. As you can see, this one has a % sign in it; and the test will fail. Otherwise, the error we catch is not a NormandyApi.InvalidSignatureError, but NS_ERROR_MALFORMED_URI. Differential Revision: https://phabricator.services.mozilla.com/D16695
testing/profiles/xpcshell/user.js
--- a/testing/profiles/xpcshell/user.js
+++ b/testing/profiles/xpcshell/user.js
@@ -1,18 +1,18 @@
 // Base preferences file used by the xpcshell harness
 /* globals user_pref */
 /* eslint quotes: 0 */
-user_pref("app.normandy.api_url", "https://%(server)s/selfsupport-dummy/");
-user_pref("browser.safebrowsing.downloads.remote.url", "https://%(server)s/safebrowsing-dummy");
-user_pref("browser.search.geoip.url", "https://%(server)s/geoip-dummy");
-user_pref("extensions.systemAddon.update.url", "http://%(server)s/dummy-system-addons.xml");
+user_pref("app.normandy.api_url", "https://localhost/selfsupport-dummy/");
+user_pref("browser.safebrowsing.downloads.remote.url", "https://localhost/safebrowsing-dummy");
+user_pref("browser.search.geoip.url", "https://localhost/geoip-dummy");
+user_pref("extensions.systemAddon.update.url", "http://localhost/dummy-system-addons.xml");
 // Always use network provider for geolocation tests
 // so we bypass the OSX dialog raised by the corelocation provider
 user_pref("geo.provider.testing", true);
 user_pref("media.gmp-manager.updateEnabled", false);
-user_pref("media.gmp-manager.url.override", "http://%(server)s/dummy-gmp-manager.xml");
-user_pref("toolkit.telemetry.server", "https://%(server)s/telemetry-dummy");
+user_pref("media.gmp-manager.url.override", "http://localhost/dummy-gmp-manager.xml");
+user_pref("toolkit.telemetry.server", "https://localhost/telemetry-dummy");
 // The process priority manager only shifts priorities when it has at least
 // one active tab. xpcshell tabs don't have any active tabs, which would mean
 // all processes would run at low priority, which is not desirable, so we
 // disable the process priority manager entirely here.
 user_pref("dom.ipc.processPriorityManager.enabled", false);